You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2017/12/04 22:24:13 UTC

[GitHub] karlpauls commented on issue #1: SLING-7134 - Script execution order is not deterministic on Java 9

karlpauls commented on issue #1: SLING-7134 - Script execution order is not deterministic on Java 9
URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1#issuecomment-349126870
 
 
   I just pushed an update with my proposals mentioned in the above comments namely,
   
   1) use the systemclassloader with a null TCCL to get nashorn on java8; and
   2) an implementation for the suggestion of @kwin  to use the serviceloader to lookup engines from bundles instead of doing in manually 
   
   The push contains updated junit tests as well and it seem to work for me with both, java8 and java9.
   
   @raducotescu, both, 1) and 2) are only suggestions. Feel free to ignore my push and apply only your original patch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services