[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2582: [Improve] support delete flink home

["wolfboys (via GitHub)" <gi...@apache.org>]

wolfboys commented on code in PR #2582:
URL: https://github.com/apache/incubator-streampark/pull/2582#discussion_r1161298827


##########
streampark-console/streampark-console-webapp/src/views/setting/FlinkHome/index.vue:
##########
@@ -61,6 +79,13 @@
     openEnvDrawer(true, res);
   }
 
+  /* delete flink home */
+  async function handleDelete(item: FlinkEnv) {
+    await fetchFlinkEnvRemove(item.id);
+    await getFlinkSetting();
+    createMessage.success('The current flink home is removed');
+  }

Review Comment:
   ```
    async function handleDelete(item: FlinkEnv) {
       const resp = await fetchFlinkEnvRemove(item.id);
       if (response.data.code == 200) {
         await getFlinkSetting();
         createMessage.success('The current flink home is removed');
       }
     }
   
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org