You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "ronething (via GitHub)" <gi...@apache.org> on 2025/06/24 01:50:58 UTC
[PR] fix(ci): lint checker [apisix-ingress-controller]
ronething opened a new pull request, #2422:
URL: https://github.com/apache/apisix-ingress-controller/pull/2422
Signed-off-by: ashing <ax...@gmail.com><!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
<!-- Select all the options from below that matches the type your PR best -->
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- [ ] Documentation
- [ ] Refactor
- [ ] Chore
- [x] CI/CD or Tests
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ci): lint checker [apisix-ingress-controller]
Posted by "ronething (via GitHub)" <gi...@apache.org>.
ronething merged PR #2422:
URL: https://github.com/apache/apisix-ingress-controller/pull/2422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ci): lint checker [apisix-ingress-controller]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2422:
URL: https://github.com/apache/apisix-ingress-controller/pull/2422#discussion_r2162857917
##########
powered-by.md:
##########
@@ -0,0 +1,41 @@
+---
+title: Powered by Apache APISIX Ingress
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+This page documents an alphabetical list of institutions that are using APISIX Ingress for research and production,
+or providing commercial products including APISIX Ingress.
+
+Users are encouraged to add themselves to this page, [issue](https://github.com/apache/apisix-ingress-controller/issues/501) and PR are welcomed.
+
+1. <a href="https://www.aispeech.com/" rel="nofollow">AISpeech 思必驰</a>
+1. <a href="https://cloud.tencent.com/" rel="nofollow">Tencent Cloud 腾讯云</a>
+1. <a href="https://www.upyun.com/" rel="nofollow">UPYUN 又拍云</a>
+1. <a href="https://www.kubegems.io/" rel="nofollow">KubeGems</a>
+1. <a href="https://www.igetcool.com/" rel="nofollow">少年得到</a>
+1. <a href="https://www.niimbot.com/" rel="nofollow">NIIMBOT 武汉精臣智慧标识科技有限公司</a>
+1. <a href="https://www.xmfunny.com/" rel="nofollow">SoFunny 厦门真有趣</a>
+1. <a href="https://zoom.us/" rel="nofollow">Zoom</a>
+1. <a href="https://referencesystem.copernicus.eu/" rel="nofollow">European Copernicus Reference System Software</a>
+1. <a href="https://www.jiakaobaodian.com/" rel="nofollow">Jiakaobaodian(驾考宝典)</a>
+1. <a href="https://www.horizon.ai/" rel="nofollow">Horizon Robotics(地平线)</a>
+1. <a href="https://www.xiaopeng.com/" rel="nofollow">小鹏汽车</a>
+1. <a href="https://laf.run/" rel="nofollow">Laf</a>
Review Comment:
[nitpick] While using the same number for every list item is valid markdown, consider using auto-incremented numbers for enhanced clarity in the rendered output.
```suggestion
2. <a href="https://cloud.tencent.com/" rel="nofollow">Tencent Cloud 腾讯云</a>
3. <a href="https://www.upyun.com/" rel="nofollow">UPYUN 又拍云</a>
4. <a href="https://www.kubegems.io/" rel="nofollow">KubeGems</a>
5. <a href="https://www.igetcool.com/" rel="nofollow">少年得到</a>
6. <a href="https://www.niimbot.com/" rel="nofollow">NIIMBOT 武汉精臣智慧标识科技有限公司</a>
7. <a href="https://www.xmfunny.com/" rel="nofollow">SoFunny 厦门真有趣</a>
8. <a href="https://zoom.us/" rel="nofollow">Zoom</a>
9. <a href="https://referencesystem.copernicus.eu/" rel="nofollow">European Copernicus Reference System Software</a>
10. <a href="https://www.jiakaobaodian.com/" rel="nofollow">Jiakaobaodian(驾考宝典)</a>
11. <a href="https://www.horizon.ai/" rel="nofollow">Horizon Robotics(地平线)</a>
12. <a href="https://www.xiaopeng.com/" rel="nofollow">小鹏汽车</a>
13. <a href="https://laf.run/" rel="nofollow">Laf</a>
```
##########
.asf.yaml:
##########
@@ -0,0 +1,54 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+github:
+ description: APISIX Ingress Controller for Kubernetes
+ homepage: https://apisix.apache.org/
+ labels:
+ - ingress
+ - kubernetes
+ - controller
+ - apisix
+ - crds
+ - k8s
+ - apigateway
+ - microservices
+ - api
+ - kubernetes-ingress
+ - loadbalancing
+ - devops
+
+ enabled_merge_buttons:
+ squash: true
+ merge: false
+ rebase: false
+ protected_branches:
+ master:
Review Comment:
The protected branch is listed as 'master', but the repository appears to use 'main' in other configurations. Consider updating this value to match the active branch to avoid potential misconfigurations.
```suggestion
main:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org