[GitHub] [hive] pvary commented on a diff in pull request #3181: HIVE-22420: Addendum

[GitBox <gi...@apache.org>]

pvary commented on code in PR #3181:
URL: https://github.com/apache/hive/pull/3181#discussion_r843745809


##########
ql/src/java/org/apache/hadoop/hive/ql/DriverTxnHandler.java:
##########
@@ -570,7 +570,7 @@ void endTransactionAndCleanup(boolean commit) throws LockException {
     txnRollbackRunner = null;
   }
 
-  void endTransactionAndCleanup(boolean commit, HiveTxnManager txnManager) throws LockException {
+  synchronized void endTransactionAndCleanup(boolean commit, HiveTxnManager txnManager) throws LockException {

Review Comment:
   Could we leave a comment here, why is this synchronized?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org