You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/03/30 04:22:51 UTC

[GitHub] [rocketmq] codecov-io commented on pull request #2758: fixed two warnings in BrokerStartUp

codecov-io commented on pull request #2758:
URL: https://github.com/apache/rocketmq/pull/2758#issuecomment-809896451


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2758?src=pr&el=h1) Report
   > Merging [#2758](https://codecov.io/gh/apache/rocketmq/pull/2758?src=pr&el=desc) (7680063) into [develop](https://codecov.io/gh/apache/rocketmq/commit/39bb9386f10d5d8dfe81183c172a3a86f6d313bd?el=desc) (39bb938) will **increase** coverage by `2.36%`.
   > The diff coverage is `30.30%`.
   
   > :exclamation: Current head 7680063 differs from pull request most recent head fd48a86. Consider uploading reports for the commit fd48a86 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2758/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv)](https://codecov.io/gh/apache/rocketmq/pull/2758?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #2758      +/-   ##
   =============================================
   + Coverage      46.14%   48.51%   +2.36%     
   + Complexity      4339     3183    -1156     
   =============================================
     Files            547      418     -129     
     Lines          36236    26379    -9857     
     Branches        4808     3505    -1303     
   =============================================
   - Hits           16722    12798    -3924     
   + Misses         17442    11931    -5511     
   + Partials        2072     1650     -422     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2758?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../rocketmq/broker/offset/ConsumerOffsetManager.java](https://codecov.io/gh/apache/rocketmq/pull/2758/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvb2Zmc2V0L0NvbnN1bWVyT2Zmc2V0TWFuYWdlci5qYXZh) | `15.70% <0.00%> (-1.58%)` | `8.00 <0.00> (ø)` | |
   | [...ocketmq/broker/processor/AdminBrokerProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2758/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0FkbWluQnJva2VyUHJvY2Vzc29yLmphdmE=) | `7.96% <0.00%> (-0.02%)` | `13.00 <0.00> (ø)` | |
   | [...l/header/DeleteSubscriptionGroupRequestHeader.java](https://codecov.io/gh/apache/rocketmq/pull/2758/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL0RlbGV0ZVN1YnNjcmlwdGlvbkdyb3VwUmVxdWVzdEhlYWRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...e/rocketmq/remoting/netty/NettyRemotingClient.java](https://codecov.io/gh/apache/rocketmq/pull/2758/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `47.24% <33.33%> (+0.32%)` | `26.00 <0.00> (ø)` | |
   | [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/2758/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `56.45% <33.33%> (-0.13%)` | `110.00 <0.00> (+1.00)` | :arrow_down: |
   | [...ache/rocketmq/broker/topic/TopicConfigManager.java](https://codecov.io/gh/apache/rocketmq/pull/2758/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvdG9waWMvVG9waWNDb25maWdNYW5hZ2VyLmphdmE=) | `59.00% <57.14%> (ø)` | `16.00 <1.00> (ø)` | |
   | [...org/apache/rocketmq/broker/out/BrokerOuterAPI.java](https://codecov.io/gh/apache/rocketmq/pull/2758/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvb3V0L0Jyb2tlck91dGVyQVBJLmphdmE=) | `46.47% <100.00%> (ø)` | `12.00 <0.00> (ø)` | |
   | [...ocketmq/broker/processor/PullMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2758/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1B1bGxNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `41.28% <100.00%> (ø)` | `19.00 <1.00> (ø)` | |
   | [...a/org/apache/rocketmq/common/filter/FilterAPI.java](https://codecov.io/gh/apache/rocketmq/pull/2758/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vZmlsdGVyL0ZpbHRlckFQSS5qYXZh) | `48.48% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
   | [.../org/apache/rocketmq/remoting/netty/TlsHelper.java](https://codecov.io/gh/apache/rocketmq/pull/2758/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L1Rsc0hlbHBlci5qYXZh) | `71.57% <100.00%> (ø)` | `15.00 <0.00> (ø)` | |
   | ... and [129 more](https://codecov.io/gh/apache/rocketmq/pull/2758/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2758?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2758?src=pr&el=footer). Last update [39bb938...fd48a86](https://codecov.io/gh/apache/rocketmq/pull/2758?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org