[jira] Updated: (DERBY-3829) Convert derbynet/sysinfo and derbynet/sysinfo_with_properties to JUnit

["Erlend Birkenes (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erlend Birkenes updated DERBY-3829:
-----------------------------------

    Attachment: Derby-3829_1.diff

Here is a complete patch. Please review and commit if it's ok.

I put both the old tests into one new one called derbynet/SysinfoTest. I thought about adding them to NetworkServerControlApiTest but I figured it would make NetworkServerControlApiTest very messy.

A few things:
The old test tested localized sysinfo, but the output from the server is not actually localized. It's exactly the same as en_US output. I included the localized test, but it tests against the same string as the en_US one. If the output is changed in the future a separate string can easily be added for localized. 
Is that ok, or should I try to find a way to test the localization?

Also, when the tests run from jars, all the locale info is not included in the output at all so I just removed it from all the tests to make it simpler. Hope that's ok too.

I added the new test to derbynet/_Suite and removed the old one and all its files (i think..), i ran the _Suite both from classes and jars.

Ok, I hope I remembered everything!

-Erlend

> Convert derbynet/sysinfo and derbynet/sysinfo_with_properties to JUnit
> ----------------------------------------------------------------------
>
>                 Key: DERBY-3829
>                 URL: https://issues.apache.org/jira/browse/DERBY-3829
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Erlend Birkenes
>            Assignee: Erlend Birkenes
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: Derby-3829_1.diff
>
>
> I'm guessing these two can be combined into one file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.