You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2023/05/05 02:10:23 UTC
[GitHub] [incubator-paimon] JingsongLi opened a new pull request, #1067: [license] Add license for bundled dependencies
JingsongLi opened a new pull request, #1067:
URL: https://github.com/apache/incubator-paimon/pull/1067
### Purpose
Fix license problem.
Copy / reference code and distribution containing binary are both bundled dependency. For copy/reference code:
1.If it is an ASF project, no copyright is added to the source code, but if there is a copyright in the NOTICE file of the related project, it needs to be added to the NOTICE file of this project. file of this project.
Reference:
https://www.apache.org/legal/src-headers.html#headers
https://infra.apache.org/licensing-howto.html#bundle-asf-product
2.If it is a non-ASF project, but the code owner is not authorized to ASF, you need to keep the copyright content in the code and mark it in the LICENSE file.
Reference:
https://www.apache.org/legal/src-headers.html#3party
https://infra.apache.org/licensing-howto.html#alv2-dep
https://infra.apache.org/licensing-howto.html#permissive-deps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] carp84 commented on a diff in pull request #1067: [license] Add license for bundled dependencies
Posted by "carp84 (via GitHub)" <gi...@apache.org>.
carp84 commented on code in PR #1067:
URL: https://github.com/apache/incubator-paimon/pull/1067#discussion_r1197472419
##########
paimon-codegen/src/main/resources/META-INF/licenses/LICENSE.scala:
##########
Review Comment:
Please also check this link for license used in scala 2.12.7 (at the bottom of the page): https://www.scala-lang.org/download/2.12.7.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] carp84 commented on pull request #1067: [license] Add license for bundled dependencies
Posted by "carp84 (via GitHub)" <gi...@apache.org>.
carp84 commented on PR #1067:
URL: https://github.com/apache/incubator-paimon/pull/1067#issuecomment-1537338118
About legal checking, aside from the changes made in this PR, please also check the below parts:
1. In the `paimon-codegen/src/main/resources/META-INF/NOTICE` file, it mentions `licenses/LICENSE.scala` which seems to be missing.
2. In the `paimon-common/src/main/resources/META-INF/NOTICE` file, it mentions dependency on [janino](https://github.com/janino-compiler/janino/blob/master/LICENSE) which seems to be missing in `paimon-common/src/main/resources/META-INF/licenses`(No LICENSE.janino file found)
3. In the `paimon-filesystems/paimon-oss-impl/src/main/resources/META-INF/NOTICE` file, it mentions dependency on [jacoco](https://github.com/jacoco/jacoco/blob/master/LICENSE.md) which seems to be missing in `paimon-filesystems/paimon-oss-impl/src/main/resources/META-INF/licenses`
4. In the `paimon-filesystems/paimon-s3-impl/src/main/resources/META-INF/NOTICE` file, it mentions many dependencies but only license files for `re2j`, `stax2api` and `jaxb` appear in `paimon-filesystems/paimon-s3-impl/src/main/resources/META-INF/licenses`
5. In the `paimon-filesystems/paimon-hadoop-shaded/src/main/resources/META-INF/NOTICE` file, it mentions more dependencies than what's presenting in `paimon-filesystems/paimon-hadoop-shaded/src/main/resources/META-INF/licenses`
6. In the `paimon-format/src/main/resources/META-INF/NOTICE` file, it mentions [protobuf-java](https://github.com/protocolbuffers/protobuf/blob/main/LICENSE) while there's no license file presented
I suggest to check whether we are really bundling the dependencies as recorded in the nested NOTICE file under different sub-modules, and make fix accordingly (removing the dependency from NOTICE file or adding license file for dependencies)
PS. I caught the above issues by running the `grep -R "Copyright" ./*` command in the source package of 0.4.0-rc3 and checking the outputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1067: [license] Add license for bundled dependencies
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #1067:
URL: https://github.com/apache/incubator-paimon/pull/1067#discussion_r1188068652
##########
paimon-codegen/src/main/resources/META-INF/licenses/LICENSE.scala:
##########
Review Comment:
> slightly different from the [LICENSE](https://github.com/scala/scala/blob/v2.12.7/LICENSE) file in scala 2.12.7 release
Updated.
> scala used BSD 3-clause license before Dec. 2018 but has [changed to ALv2](https://www.scala-lang.org/news/license-change.html) now
Thanks for the reminder~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1067: [license] Add license for bundled dependencies
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #1067:
URL: https://github.com/apache/incubator-paimon/pull/1067#discussion_r1188067696
##########
paimon-filesystems/paimon-hadoop-shaded/src/main/resources/META-INF/licenses/LICENSE.checker-framework:
##########
Review Comment:
👍🏻 I got it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi merged pull request #1067: [license] Add license for bundled dependencies
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #1067:
URL: https://github.com/apache/incubator-paimon/pull/1067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] carp84 commented on a diff in pull request #1067: [license] Add license for bundled dependencies
Posted by "carp84 (via GitHub)" <gi...@apache.org>.
carp84 commented on code in PR #1067:
URL: https://github.com/apache/incubator-paimon/pull/1067#discussion_r1188051907
##########
licenses/LICENSE.aws:
##########
Review Comment:
For dependencies with standard ALv2, we don't need to duplicate the license content according to the instructions [here](https://infra.apache.org/licensing-howto.html#alv2-dep). The same applies to `LICENSE.paldb`
##########
paimon-codegen/src/main/resources/META-INF/licenses/LICENSE.scala:
##########
Review Comment:
It seems that this file is slightly different from the [LICENSE](https://github.com/scala/scala/blob/v2.12.7/LICENSE) file in scala 2.12.7 release, especially on the copyright year part.
btw, scala used BSD 3-clause license before Dec. 2018 but has [changed to ALv2](https://www.scala-lang.org/news/license-change.html) now, we may notice to update the license file if change the dependency version in future (2.12.7 was released in Sep. 2018 so BSD-3 still).
##########
paimon-filesystems/paimon-oss-impl/src/main/resources/META-INF/licenses/LICENSE.eclipse:
##########
Review Comment:
I think we should use the [license file under jacoco 0.8.5 release](https://github.com/jacoco/jacoco/blob/v0.8.5/LICENSE.md) instead, which includes the copyright content.
##########
paimon-filesystems/paimon-hadoop-shaded/src/main/resources/META-INF/licenses/LICENSE.checker-framework:
##########
Review Comment:
We should use the [license under the checker-qual module](https://github.com/typetools/checker-framework/blob/master/checker-qual/LICENSE.txt) instead, which is an MIT license. The license of the whole checker-framework project is GNU GPL2 which is under [category-X](https://www.apache.org/legal/resolved.html#category-x) and is not permissive to use in ASF projects.
Related, I suggest to rename this file as `LICENSE.checker-qual` (and update the reference in the NOTICE file accordingly)
##########
paimon-filesystems/paimon-s3-impl/src/main/resources/META-INF/licenses/LICENSE.checker-framework:
##########
Review Comment:
Ditto, please use the checker-qual MIT license instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] carp84 commented on a diff in pull request #1067: [license] Add license for bundled dependencies
Posted by "carp84 (via GitHub)" <gi...@apache.org>.
carp84 commented on code in PR #1067:
URL: https://github.com/apache/incubator-paimon/pull/1067#discussion_r1186788252
##########
paimon-common/src/main/java/org/apache/paimon/lookup/hash/HashLookupStoreReader.java:
##########
@@ -1,19 +1,15 @@
/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
+ * Copyright 2015 LinkedIn Corp. All rights reserved.
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
*/
/* This file is based on source code from the PalDB Project (https://github.com/linkedin/PalDB), licensed by the Apache
Review Comment:
Minor: this refers to the [StorageReader](https://github.com/linkedin/PalDB/blob/d05ccdd3f67855eb2675dbd82599f19aa7a9f650/paldb/src/main/java/com/linkedin/paldb/impl/StorageReader.java) class, right? If so, how about mentioning the file name?
```suggestion
/* This file is based on source code of StorageReader from the PalDB Project (https://github.com/linkedin/PalDB), licensed by the Apache
```
##########
paimon-common/src/main/java/org/apache/paimon/utils/VarLengthIntUtils.java:
##########
@@ -12,6 +12,10 @@
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
*/
+/* This file is based on source code from the PalDB Project (https://github.com/linkedin/PalDB), licensed by the Apache
Review Comment:
Minor: this refers to the [LongPacker](https://github.com/linkedin/PalDB/blob/d05ccdd3f67855eb2675dbd82599f19aa7a9f650/paldb/src/main/java/com/linkedin/paldb/utils/LongPacker.java) class, right? If so, how about mentioning the file name?
```suggestion
/* This file is based on source code of LongPacker from the PalDB Project (https://github.com/linkedin/PalDB), licensed by the Apache
```
##########
paimon-common/src/main/java/org/apache/paimon/lookup/hash/HashLookupStoreWriter.java:
##########
@@ -1,19 +1,15 @@
/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
+ * Copyright 2015 LinkedIn Corp. All rights reserved.
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
*/
/* This file is based on source code from the PalDB Project (https://github.com/linkedin/PalDB), licensed by the Apache
Review Comment:
Minor: this refers to the [StorageWriter](https://github.com/linkedin/PalDB/blob/d05ccdd3f67855eb2675dbd82599f19aa7a9f650/paldb/src/main/java/com/linkedin/paldb/impl/StorageWriter.java) class, right? If so, how about mentioning the file name?
```suggestion
/* This file is based on source code of StorageWriter from the PalDB Project (https://github.com/linkedin/PalDB), licensed by the Apache
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org