You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Vinod Kone (JIRA)" <ji...@apache.org> on 2017/02/14 06:48:41 UTC

[jira] [Commented] (MESOS-7115) Agent should prefer LOG(FATAL) over EXIT().

    [ https://issues.apache.org/jira/browse/MESOS-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865198#comment-15865198 ] 

Vinod Kone commented on MESOS-7115:
-----------------------------------

An issue with LOG(FATAL) is that it prints stack traces; that's why we pick EXIT(1) in scenarios where we don't want to print stack traces, because most users find stack traces scary. 

I think a better solution would be to improve EXIT(1) to include the require metadata. Maybe EXIT could do LOG(ERROR) and exit?

> Agent should prefer LOG(FATAL) over EXIT().
> -------------------------------------------
>
>                 Key: MESOS-7115
>                 URL: https://issues.apache.org/jira/browse/MESOS-7115
>             Project: Mesos
>          Issue Type: Bug
>          Components: agent
>            Reporter: James Peach
>            Priority: Minor
>
> I saw the agent exit with an auth failure:
> {noformat}
> I0210 14:16:49.731459  9503 authenticatee.cpp:259] Received SASL authentication step
> Master master@17.174.144.199:5050 refused authentication
> {noformat}
> Note the lack of log metadata on the exit message. This message (from {{slave.cpp}} and a number of others in the same file should all use {{LOG(FATAL)}} so that log aggregation can pick up the timestamp, error severity, etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)