You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/08/06 12:03:00 UTC
[jira] [Commented] (YARN-10793) Upgrade Junit from 4 to 5 in hadoop-yarn-server-applicationhistoryservice
[ https://issues.apache.org/jira/browse/YARN-10793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576188#comment-17576188 ]
ASF GitHub Bot commented on YARN-10793:
---------------------------------------
aajisaka commented on code in PR #4603:
URL: https://github.com/apache/hadoop/pull/4603#discussion_r939521173
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryClientService.java:
##########
@@ -18,6 +18,11 @@
package org.apache.hadoop.yarn.server.applicationhistoryservice;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
Review Comment:
Would you move the static imports to the bottom?
> Upgrade Junit from 4 to 5 in hadoop-yarn-server-applicationhistoryservice
> -------------------------------------------------------------------------
>
> Key: YARN-10793
> URL: https://issues.apache.org/jira/browse/YARN-10793
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: ANANDA G B
> Assignee: groot
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Upgrade Junit from 4 to 5 in hadoop-yarn-server-applicationhistoryservice
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org