You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2014/09/26 23:09:09 UTC
[GitHub] incubator-brooklyn pull request: Fix softlayer: delete custom code...
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/193
Fix softlayer: delete custom code; rely on jclouds
The SoftLayerFastVirtualGuestToNodeMetadata broke softlayer for me: when I provisioned a VM, the NodeMetadata returned had a null imageId and null OperatingSystem, which caused an NPE in JcloudsLocation.createUser.
Deleting that class to rely on normal jclouds 1.8 fixed the problem for me.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/softlayer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #193
----
commit 4318230dbf09490d2263451db1493291bac6b55d
Author: Aled Sage <al...@gmail.com>
Date: 2014-09-26T21:07:10Z
Fix softlayer: delete custom code; rely on jclouds
- The SoftLayerFastVirtualGuestToNodeMetadata broke softlayer for me:
when I provisioned a VM, the NodeMetadata returned had a null imageId
and null OperatingSystem, which caused an NPE in
JcloudsLocation.createUser.
- Deleting that class to rely on normal jclouds 1.8 fixed the problem
for me.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix softlayer: delete custom code...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/193#issuecomment-57021029
@andreaturli @ahgittin can you review please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix softlayer: delete custom code...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix softlayer: delete custom code...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/193#issuecomment-57166134
Sure @aledsage, it should be fixed on 1.8.0
Please merge it
Andrea
Il 29/set/2014 16:08 "Aled Sage" <no...@github.com> ha scritto:
> I spoke to @andreaturli <https://github.com/andreaturli> about it when
> debugging. He confirmed verbally that this should not be needed.
>
> The code for injecting the class override will be in version control, so
> I'll continue with the delete if that's ok.
>
> Merging.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-brooklyn/pull/193#issuecomment-57165807>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix softlayer: delete custom code...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/193#issuecomment-57035271
good move. i think @andreaturli 's fixes from this class were incorporated in 1.8 so no more need for this. can you confirm @andreaturli ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix softlayer: delete custom code...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/193#discussion_r18120077
--- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsUtil.java ---
@@ -318,8 +317,7 @@ public static ComputeService findComputeService(ConfigBag conf, boolean allowReu
return ImmutableSet.<Module> of(
new SshjSshClientModule(),
new SLF4JLoggingModule(),
- new BouncyCastleCryptoModule(),
- new BrooklynStandardJcloudsGuiceModule());
--- End diff --
i'd kinda like to keep this even if empty because it was *painful* to figure out how to do it and i'd hate to go through that again. but then again i'm not likely to forget it so fine to delete it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix softlayer: delete custom code...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/193#issuecomment-57165807
I spoke to @andreaturli about it when debugging. He confirmed verbally that this should not be needed.
The code for injecting the class override will be in version control, so I'll continue with the delete if that's ok.
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---