You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/07/18 22:51:46 UTC
Review Request 12744: Removed unused classes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12744/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
ScriptBuilder and Executor was not actually used.
Diffs
-----
utils/src/com/cloud/utils/script/Executor.java 4e70a77
utils/src/com/cloud/utils/script/Script.java d3a3591
utils/src/com/cloud/utils/script/ScriptBuilder.java 96cadfb
Diff: https://reviews.apache.org/r/12744/diff/
Testing
-------
Thanks,
Laszlo Hornyak
Re: Review Request 12744: Removed unused classes
Posted by Sheng Yang <sh...@yasker.org>.
> On July 18, 2013, 10:42 p.m., Sheng Yang wrote:
> > Ship It!
Pushed to MASTER.
- Sheng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12744/#review23444
-----------------------------------------------------------
On July 18, 2013, 8:51 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12744/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 8:51 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> ScriptBuilder and Executor was not actually used.
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/script/Executor.java 4e70a77
> utils/src/com/cloud/utils/script/Script.java d3a3591
> utils/src/com/cloud/utils/script/ScriptBuilder.java 96cadfb
>
> Diff: https://reviews.apache.org/r/12744/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 12744: Removed unused classes
Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12744/#review23444
-----------------------------------------------------------
Ship it!
Ship It!
- Sheng Yang
On July 18, 2013, 8:51 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12744/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 8:51 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> ScriptBuilder and Executor was not actually used.
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/script/Executor.java 4e70a77
> utils/src/com/cloud/utils/script/Script.java d3a3591
> utils/src/com/cloud/utils/script/ScriptBuilder.java 96cadfb
>
> Diff: https://reviews.apache.org/r/12744/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>