You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Aniruddha Laud <i0...@yahoo.com> on 2012/09/12 02:17:29 UTC
Re: Review Request: Add a rebalancer thread to redistribute topics equally
among hubs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6700/
-----------------------------------------------------------
(Updated Sept. 12, 2012, 12:17 a.m.)
Review request for bookkeeper, Ivan Kelly and Sijie Guo.
Changes
-------
Allow configuration of a minimum load to trigger rebalances.
Description
-------
https://issues.apache.org/jira/browse/BOOKKEEPER-363
Diffs (updated)
-----
hedwig-server/src/main/java/org/apache/hedwig/server/common/ServerConfiguration.java 9bef0f4
hedwig-server/src/main/java/org/apache/hedwig/server/topics/AbstractTopicManager.java 9353b7f
hedwig-server/src/main/java/org/apache/hedwig/server/topics/HubLoad.java 79f7922
hedwig-server/src/main/java/org/apache/hedwig/server/topics/HubServerManager.java 83c0e86
hedwig-server/src/main/java/org/apache/hedwig/server/topics/MMTopicManager.java dbec795
hedwig-server/src/main/java/org/apache/hedwig/server/topics/TopicBasedLoadShedder.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/topics/TopicManager.java b425448
hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkHubServerManager.java 7482d5a
hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java 128a1aa
hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestTopicBasedLoadShedder.java PRE-CREATION
Diff: https://reviews.apache.org/r/6700/diff/
Testing
-------
"mvn clean && mvn package" passes
TODO: Add a test for ZkHubServerManager.
Thanks,
Aniruddha Laud
Re: Review Request: Add a rebalancer thread to redistribute topics equally
among hubs
Posted by Sijie Guo <gu...@gmail.com>.
> On Sept. 19, 2012, 2:23 p.m., Ivan Kelly wrote:
> > Good changes. I have a few small comments below. Also, you should set the bug field in review board to the JIRA id. This way, review board will post to the jira when people review.
Currently the bound between review board and jira was broken. so even you set the JIRA id, the review comments doesn't post to JIRA. I created an INFRA jira to them. https://issues.apache.org/jira/browse/INFRA-5110
but seems that they marked as 'won't fix' due to upstream issues.
- Sijie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6700/#review11691
-----------------------------------------------------------
On Sept. 12, 2012, 12:17 a.m., Aniruddha Laud wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6700/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2012, 12:17 a.m.)
>
>
> Review request for bookkeeper, Ivan Kelly and Sijie Guo.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/BOOKKEEPER-363
>
>
> Diffs
> -----
>
> hedwig-server/src/main/java/org/apache/hedwig/server/common/ServerConfiguration.java 9bef0f4
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/AbstractTopicManager.java 9353b7f
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/HubLoad.java 79f7922
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/HubServerManager.java 83c0e86
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/MMTopicManager.java dbec795
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/TopicBasedLoadShedder.java PRE-CREATION
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/TopicManager.java b425448
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkHubServerManager.java 7482d5a
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java 128a1aa
> hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestTopicBasedLoadShedder.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6700/diff/
>
>
> Testing
> -------
>
> "mvn clean && mvn package" passes
> TODO: Add a test for ZkHubServerManager.
>
>
> Thanks,
>
> Aniruddha Laud
>
>
Re: Review Request: Add a rebalancer thread to redistribute topics equally
among hubs
Posted by Ivan Kelly <iv...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6700/#review11691
-----------------------------------------------------------
Good changes. I have a few small comments below. Also, you should set the bug field in review board to the JIRA id. This way, review board will post to the jira when people review.
hedwig-server/src/main/java/org/apache/hedwig/server/topics/HubServerManager.java
<https://reviews.apache.org/r/6700/#comment25269>
Should use HubLoad rather than HubLoadData as parameter
hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkHubServerManager.java
<https://reviews.apache.org/r/6700/#comment25270>
MMTopicManager already gets a scheduler from PubSubServer. You should use this one.
hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestTopicBasedLoadShedder.java
<https://reviews.apache.org/r/6700/#comment25271>
This TODO should be resolved before we commit.
- Ivan Kelly
On Sept. 12, 2012, 12:17 a.m., Aniruddha Laud wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6700/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2012, 12:17 a.m.)
>
>
> Review request for bookkeeper, Ivan Kelly and Sijie Guo.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/BOOKKEEPER-363
>
>
> Diffs
> -----
>
> hedwig-server/src/main/java/org/apache/hedwig/server/common/ServerConfiguration.java 9bef0f4
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/AbstractTopicManager.java 9353b7f
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/HubLoad.java 79f7922
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/HubServerManager.java 83c0e86
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/MMTopicManager.java dbec795
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/TopicBasedLoadShedder.java PRE-CREATION
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/TopicManager.java b425448
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkHubServerManager.java 7482d5a
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java 128a1aa
> hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestTopicBasedLoadShedder.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6700/diff/
>
>
> Testing
> -------
>
> "mvn clean && mvn package" passes
> TODO: Add a test for ZkHubServerManager.
>
>
> Thanks,
>
> Aniruddha Laud
>
>
Re: Review Request: Add a rebalancer thread to redistribute topics equally
among hubs
Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6700/#review11659
-----------------------------------------------------------
Ship it!
Ship It!
- Sijie Guo
On Sept. 12, 2012, 12:17 a.m., Aniruddha Laud wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6700/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2012, 12:17 a.m.)
>
>
> Review request for bookkeeper, Ivan Kelly and Sijie Guo.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/BOOKKEEPER-363
>
>
> Diffs
> -----
>
> hedwig-server/src/main/java/org/apache/hedwig/server/common/ServerConfiguration.java 9bef0f4
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/AbstractTopicManager.java 9353b7f
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/HubLoad.java 79f7922
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/HubServerManager.java 83c0e86
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/MMTopicManager.java dbec795
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/TopicBasedLoadShedder.java PRE-CREATION
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/TopicManager.java b425448
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkHubServerManager.java 7482d5a
> hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java 128a1aa
> hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestTopicBasedLoadShedder.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6700/diff/
>
>
> Testing
> -------
>
> "mvn clean && mvn package" passes
> TODO: Add a test for ZkHubServerManager.
>
>
> Thanks,
>
> Aniruddha Laud
>
>