You are viewing a plain text version of this content. The canonical link for it is here.
Posted to geb-dev@groovy.apache.org by "jonnybot0 (via GitHub)" <gi...@apache.org> on 2024/12/23 16:30:51 UTC
[PR] Fix codenarc space error [groovy-geb]
jonnybot0 opened a new pull request, #240:
URL: https://github.com/apache/groovy-geb/pull/240
I noticed that codenarc was failing in CircleCI due to SpaceAfterCommentDelimiter violations. This was a quick fix with a regex, so I'm going to just merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: geb-dev-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix codenarc space error [groovy-geb]
Posted by "jonnybot0 (via GitHub)" <gi...@apache.org>.
jonnybot0 merged PR #240:
URL: https://github.com/apache/groovy-geb/pull/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: geb-dev-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix codenarc space error [groovy-geb]
Posted by "jonnybot0 (via GitHub)" <gi...@apache.org>.
jonnybot0 commented on PR #240:
URL: https://github.com/apache/groovy-geb/pull/240#issuecomment-2560428582
The main difference was that the previous style check workflow was only running codenarcMain. `check` will also run `codenarcTest`, along with `test`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: geb-notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix codenarc space error [groovy-geb]
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert commented on PR #240:
URL: https://github.com/apache/groovy-geb/pull/240#issuecomment-2560305522
We should check the Codenarc config between what the GitHub action is running and what CircleCI is running. If CircleCI is failing, I would have thought the GitHub action should have failed too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: geb-notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org