You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/01 12:50:18 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5132: vnc: Decouple VNC server from NX graphic stack
xiaoxiang781216 commented on a change in pull request #5132:
URL: https://github.com/apache/incubator-nuttx/pull/5132#discussion_r777107390
##########
File path: include/nuttx/nx/nx.h
##########
@@ -258,6 +259,49 @@ extern "C"
* Public Function Prototypes
****************************************************************************/
+/****************************************************************************
+ * Name: nx_vnc_fbinitialize
+ *
+ * Description:
+ * This is just a wrapper around vnc_fbinitialize() that will establish
+ * the default mouse and keyboard callout functions.
+ *
+ * Input Parameters:
+ * display - In the case of hardware with multiple displays, this
+ * specifies the display. Normally this is zero.
+ * handle - And instance of NXHANDLE returned from initialization of the
+ * NX graphics system for that display.
+ *
+ * Returned Value:
+ * Zero (OK) is returned on success. Otherwise, a negated errno value is
+ * returned to indicate the nature of the failure.
+ *
+ ****************************************************************************/
+
+/* int nx_vnc_fbinitialize(int display, NXHANDLE handle); */
+
+#if defined(CONFIG_NX_KBD) && defined(CONFIG_NX_XYINPUT)
+
+#define nx_vnc_fbinitialize(d,h) \
Review comment:
Done.
##########
File path: include/nuttx/nx/nx.h
##########
@@ -258,6 +259,49 @@ extern "C"
* Public Function Prototypes
****************************************************************************/
+/****************************************************************************
+ * Name: nx_vnc_fbinitialize
+ *
+ * Description:
+ * This is just a wrapper around vnc_fbinitialize() that will establish
+ * the default mouse and keyboard callout functions.
+ *
+ * Input Parameters:
+ * display - In the case of hardware with multiple displays, this
+ * specifies the display. Normally this is zero.
+ * handle - And instance of NXHANDLE returned from initialization of the
+ * NX graphics system for that display.
+ *
+ * Returned Value:
+ * Zero (OK) is returned on success. Otherwise, a negated errno value is
+ * returned to indicate the nature of the failure.
+ *
+ ****************************************************************************/
+
+/* int nx_vnc_fbinitialize(int display, NXHANDLE handle); */
+
+#if defined(CONFIG_NX_KBD) && defined(CONFIG_NX_XYINPUT)
+
+#define nx_vnc_fbinitialize(d,h) \
+ vnc_fbinitialize((d), nx_kbdin, nx_mousein, (FAR void *)(h))
+
+#elif defined(CONFIG_NX_KBD)
+
+#define nx_vnc_fbinitialize(d,h) \
+ vnc_fbinitialize((d), nx_kbdin, NULL, (FAR void *)(h))
+
+#elif defined(CONFIG_NX_XYINPUT)
+
+#define nx_vnc_fbinitialize(d,h) \
Review comment:
Done.
##########
File path: include/nuttx/nx/nx.h
##########
@@ -258,6 +259,49 @@ extern "C"
* Public Function Prototypes
****************************************************************************/
+/****************************************************************************
+ * Name: nx_vnc_fbinitialize
+ *
+ * Description:
+ * This is just a wrapper around vnc_fbinitialize() that will establish
+ * the default mouse and keyboard callout functions.
+ *
+ * Input Parameters:
+ * display - In the case of hardware with multiple displays, this
+ * specifies the display. Normally this is zero.
+ * handle - And instance of NXHANDLE returned from initialization of the
+ * NX graphics system for that display.
+ *
+ * Returned Value:
+ * Zero (OK) is returned on success. Otherwise, a negated errno value is
+ * returned to indicate the nature of the failure.
+ *
+ ****************************************************************************/
+
+/* int nx_vnc_fbinitialize(int display, NXHANDLE handle); */
+
+#if defined(CONFIG_NX_KBD) && defined(CONFIG_NX_XYINPUT)
+
+#define nx_vnc_fbinitialize(d,h) \
+ vnc_fbinitialize((d), nx_kbdin, nx_mousein, (FAR void *)(h))
+
+#elif defined(CONFIG_NX_KBD)
+
+#define nx_vnc_fbinitialize(d,h) \
+ vnc_fbinitialize((d), nx_kbdin, NULL, (FAR void *)(h))
+
+#elif defined(CONFIG_NX_XYINPUT)
+
+#define nx_vnc_fbinitialize(d,h) \
+ vnc_fbinitialize((d), NULL, nx_mousein, (FAR void *)(h))
+
+#else
+
+#define nx_vnc_fbinitialize(d,h) \
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org