You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Jarek Gawor <jg...@gmail.com> on 2007/04/13 07:28:15 UTC
jaxrpc ejb web services support in Geronimo
Hi folks,
I'm working on getting jaxrpc ejb support working again in Geronimo.
I believe I have everything setup ok in Geronimo and now I'm running
into the following problems in OpenEJB:
1) In org.apache.openejb.core.stateless.StatelessContainer the
isWebServiceCall() function returns false because the
deployment.getServiceEndpointInterface() function returns null. But I
think the getServiceEndpointInterfaceName() returns a non null value
(service endpoint interface is set in the DD).
2) If 1) is fixed then I see
org.apache.openejb.core.interceptor.ReflectionInvocationContext.proceed()
function raise "Parameters have not been set" exception. The the
jaxrpc interceptor (in
org.apache.openejb.server.axis.EjbContainerProvider) is supposed to
set the parameters but the parameters check in
ReflectionInvocationContext.proceed() is done before the interceptors
are invoked.
3) And if 2) if fixed then the jaxrpc interceptor is not getting
invoked at all. I'm not sure what's going on with that.
I have a test case in Geronimo code base to test this integration (in
'testsuite/webservices-testsuite/jaxrpc-tests/jaxrpc-ejb" directory).
Both
"testInvocation" and "testWSDL" tests should pass (the "testEJB" test
case always fails so can be ignored for now).
I would appreciate if somebody could fix or take a closer look at
these problems.
Let me know if you have any questions, etc.
Thanks,
Jarek
Re: Web Service Provider and OpenEJB integration (was: Re: jaxrpc ejb web services support in Geronimo)
Posted by Jarek Gawor <jg...@gmail.com>.
Jacek,
First of all, thanks a lot! Everything looks and works well for me
except one little issue with the test case (it did not get updated
properly). I reopened
https://issues.apache.org/jira/browse/OPENEJB-569 and added a new
patch for the test case.
Dzienki jeszcze raz,
Jarek
On 4/24/07, Jacek Laskowski <ja...@laskowski.net.pl> wrote:
> On 4/24/07, Jarek Gawor <jg...@gmail.com> wrote:
> > Can someone please review, comment or commit these patches?
>
> Done. I haven't built G after them so start praying it won't get
> broken due to it ;-)
>
> Thanks Jarek for the patches and apologies for the very late commit.
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.JacekLaskowski.pl
>
Re: Web Service Provider and OpenEJB integration (was: Re: jaxrpc ejb web services support in Geronimo)
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 4/24/07, Jarek Gawor <jg...@gmail.com> wrote:
> Can someone please review, comment or commit these patches?
Done. I haven't built G after them so start praying it won't get
broken due to it ;-)
Thanks Jarek for the patches and apologies for the very late commit.
Jacek
--
Jacek Laskowski
http://www.JacekLaskowski.pl
Re: Web Service Provider and OpenEJB integration (was: Re: jaxrpc ejb web services support in Geronimo)
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 4/24/07, Jarek Gawor <jg...@gmail.com> wrote:
> Can someone please review, comment or commit these patches?
Witaj Jarek!
I'm not familiar with ws bits, but will gladly review it to get more
insights on how it works.
Jacek
--
Jacek Laskowski
http://www.JacekLaskowski.pl
Re: Web Service Provider and OpenEJB integration (was: Re: jaxrpc ejb web services support in Geronimo)
Posted by Jarek Gawor <jg...@gmail.com>.
Can someone please review, comment or commit these patches?
Thanks,
Jarek
On 4/20/07, Jarek Gawor <jg...@gmail.com> wrote:
> Hi folks,
>
> I have two patches open:
>
> 1) https://issues.apache.org/jira/browse/OPENEJB-568 (improves handler
> chain processing for JAX-RPC/Axis1)
>
> 2) https://issues.apache.org/jira/browse/OPENEJB-569 (support for
> @Resource WebServiceContext injection for JAX-WS)
>
> I would applicate if somebody could review, comment, or apply these
> patches. I think the second one needs to be more carefully reviewed as
> I'm not sure if that's the right / most appropriate way of handling
> the WebServiceContext injection.
>
> Thanks,
> Jarek
>
> On 4/18/07, Jarek Gawor <jg...@gmail.com> wrote:
> > With a few additional changes
> > (https://issues.apache.org/jira/browse/OPENEJB-564) the Geronimo test
> > case I have appears to be working now. Thanks everybody for help! I
> > will try to work on the JAX-WS test case now (and I'm sure I will need
> > help with that too :)).
> >
> > Thanks again,
> > Jarek
> >
> > On 4/18/07, Manu George <ma...@gmail.com> wrote:
> > > Hi,
> > >
> > > I was thinking of where to put that code. Thanks for the advice David
> > > will do that.
> > >
> > > Regards
> > > Manu
> > >
> > > On 4/18/07, David Blevins <da...@visi.com> wrote:
> > > >
> > > > On Apr 17, 2007, at 11:51 AM, Manu George wrote:
> > > >
> > > > > Hi,
> > > > > I just attached a patch to
> > > > > https://issues.apache.org/jira/browse/OPENEJB-563. Its something i put
> > > > > together fast. It works (Test Case runs fine). David can you give it a
> > > > > look and point out any issues.
> > > >
> > > > Looks great, Manu!
> > > >
> > > > Couple thoughts I had. We should be able to set the MessageContext
> > > > in the ThreadContext in container's "if (isWebService...)" block
> > > > which would eliminate the large chunk that seems to do it in the
> > > > ReflectionInvocationContext. As far as the parameters go I totally
> > > > forgot to add an assertEquals to verify the bean gets "Hello World"
> > > > as the arg and is able to return it. We should definitely add that.
> > > >
> > > > Feel free to check it in as is then update or update it then check it
> > > > in, whatever you like. It's good to go!
> > > >
> > > > Jarek, thanks for patch OPENEJB-562! Applying it now. Any chance
> > > > you'll be able to do the JAX-WS version of the JAX-RPC test case?
> > > > Manu and/or some else might be able to help get that running too.
> > > > Let us know what your thoughts are.
> > > >
> > > > Thanks,
> > > > David
> > > >
> > > >
> > > > > Regards
> > > > > Manu
> > > > >
> > > > > On 4/17/07, Jacek Laskowski <ja...@laskowski.net.pl> wrote:
> > > > >> On 4/16/07, Manu George <ma...@gmail.com> wrote:
> > > > >> > I would like to volunteer for this task :). Anyone else
> > > > >> interested to join me ?
> > > > >>
> > > > >> I'll surely be watching your steps, but can't commit any time on it
> > > > >> yet. I'd like to throw some fresh air to the assembly module.
> > > > >>
> > > > >> Jacek
> > > > >>
> > > > >> --
> > > > >> Jacek Laskowski
> > > > >> http://www.JacekLaskowski.pl
> > > > >>
> > > > >
> > > >
> > > >
> > >
> >
>
Re: Web Service Provider and OpenEJB integration (was: Re: jaxrpc ejb web services support in Geronimo)
Posted by Jarek Gawor <jg...@gmail.com>.
Hi folks,
I have two patches open:
1) https://issues.apache.org/jira/browse/OPENEJB-568 (improves handler
chain processing for JAX-RPC/Axis1)
2) https://issues.apache.org/jira/browse/OPENEJB-569 (support for
@Resource WebServiceContext injection for JAX-WS)
I would applicate if somebody could review, comment, or apply these
patches. I think the second one needs to be more carefully reviewed as
I'm not sure if that's the right / most appropriate way of handling
the WebServiceContext injection.
Thanks,
Jarek
On 4/18/07, Jarek Gawor <jg...@gmail.com> wrote:
> With a few additional changes
> (https://issues.apache.org/jira/browse/OPENEJB-564) the Geronimo test
> case I have appears to be working now. Thanks everybody for help! I
> will try to work on the JAX-WS test case now (and I'm sure I will need
> help with that too :)).
>
> Thanks again,
> Jarek
>
> On 4/18/07, Manu George <ma...@gmail.com> wrote:
> > Hi,
> >
> > I was thinking of where to put that code. Thanks for the advice David
> > will do that.
> >
> > Regards
> > Manu
> >
> > On 4/18/07, David Blevins <da...@visi.com> wrote:
> > >
> > > On Apr 17, 2007, at 11:51 AM, Manu George wrote:
> > >
> > > > Hi,
> > > > I just attached a patch to
> > > > https://issues.apache.org/jira/browse/OPENEJB-563. Its something i put
> > > > together fast. It works (Test Case runs fine). David can you give it a
> > > > look and point out any issues.
> > >
> > > Looks great, Manu!
> > >
> > > Couple thoughts I had. We should be able to set the MessageContext
> > > in the ThreadContext in container's "if (isWebService...)" block
> > > which would eliminate the large chunk that seems to do it in the
> > > ReflectionInvocationContext. As far as the parameters go I totally
> > > forgot to add an assertEquals to verify the bean gets "Hello World"
> > > as the arg and is able to return it. We should definitely add that.
> > >
> > > Feel free to check it in as is then update or update it then check it
> > > in, whatever you like. It's good to go!
> > >
> > > Jarek, thanks for patch OPENEJB-562! Applying it now. Any chance
> > > you'll be able to do the JAX-WS version of the JAX-RPC test case?
> > > Manu and/or some else might be able to help get that running too.
> > > Let us know what your thoughts are.
> > >
> > > Thanks,
> > > David
> > >
> > >
> > > > Regards
> > > > Manu
> > > >
> > > > On 4/17/07, Jacek Laskowski <ja...@laskowski.net.pl> wrote:
> > > >> On 4/16/07, Manu George <ma...@gmail.com> wrote:
> > > >> > I would like to volunteer for this task :). Anyone else
> > > >> interested to join me ?
> > > >>
> > > >> I'll surely be watching your steps, but can't commit any time on it
> > > >> yet. I'd like to throw some fresh air to the assembly module.
> > > >>
> > > >> Jacek
> > > >>
> > > >> --
> > > >> Jacek Laskowski
> > > >> http://www.JacekLaskowski.pl
> > > >>
> > > >
> > >
> > >
> >
>
Re: Web Service Provider and OpenEJB integration (was: Re: jaxrpc ejb web services support in Geronimo)
Posted by Jarek Gawor <jg...@gmail.com>.
With a few additional changes
(https://issues.apache.org/jira/browse/OPENEJB-564) the Geronimo test
case I have appears to be working now. Thanks everybody for help! I
will try to work on the JAX-WS test case now (and I'm sure I will need
help with that too :)).
Thanks again,
Jarek
On 4/18/07, Manu George <ma...@gmail.com> wrote:
> Hi,
>
> I was thinking of where to put that code. Thanks for the advice David
> will do that.
>
> Regards
> Manu
>
> On 4/18/07, David Blevins <da...@visi.com> wrote:
> >
> > On Apr 17, 2007, at 11:51 AM, Manu George wrote:
> >
> > > Hi,
> > > I just attached a patch to
> > > https://issues.apache.org/jira/browse/OPENEJB-563. Its something i put
> > > together fast. It works (Test Case runs fine). David can you give it a
> > > look and point out any issues.
> >
> > Looks great, Manu!
> >
> > Couple thoughts I had. We should be able to set the MessageContext
> > in the ThreadContext in container's "if (isWebService...)" block
> > which would eliminate the large chunk that seems to do it in the
> > ReflectionInvocationContext. As far as the parameters go I totally
> > forgot to add an assertEquals to verify the bean gets "Hello World"
> > as the arg and is able to return it. We should definitely add that.
> >
> > Feel free to check it in as is then update or update it then check it
> > in, whatever you like. It's good to go!
> >
> > Jarek, thanks for patch OPENEJB-562! Applying it now. Any chance
> > you'll be able to do the JAX-WS version of the JAX-RPC test case?
> > Manu and/or some else might be able to help get that running too.
> > Let us know what your thoughts are.
> >
> > Thanks,
> > David
> >
> >
> > > Regards
> > > Manu
> > >
> > > On 4/17/07, Jacek Laskowski <ja...@laskowski.net.pl> wrote:
> > >> On 4/16/07, Manu George <ma...@gmail.com> wrote:
> > >> > I would like to volunteer for this task :). Anyone else
> > >> interested to join me ?
> > >>
> > >> I'll surely be watching your steps, but can't commit any time on it
> > >> yet. I'd like to throw some fresh air to the assembly module.
> > >>
> > >> Jacek
> > >>
> > >> --
> > >> Jacek Laskowski
> > >> http://www.JacekLaskowski.pl
> > >>
> > >
> >
> >
>
Re: Web Service Provider and OpenEJB integration (was: Re: jaxrpc ejb web services support in Geronimo)
Posted by Manu George <ma...@gmail.com>.
Hi,
I was thinking of where to put that code. Thanks for the advice David
will do that.
Regards
Manu
On 4/18/07, David Blevins <da...@visi.com> wrote:
>
> On Apr 17, 2007, at 11:51 AM, Manu George wrote:
>
> > Hi,
> > I just attached a patch to
> > https://issues.apache.org/jira/browse/OPENEJB-563. Its something i put
> > together fast. It works (Test Case runs fine). David can you give it a
> > look and point out any issues.
>
> Looks great, Manu!
>
> Couple thoughts I had. We should be able to set the MessageContext
> in the ThreadContext in container's "if (isWebService...)" block
> which would eliminate the large chunk that seems to do it in the
> ReflectionInvocationContext. As far as the parameters go I totally
> forgot to add an assertEquals to verify the bean gets "Hello World"
> as the arg and is able to return it. We should definitely add that.
>
> Feel free to check it in as is then update or update it then check it
> in, whatever you like. It's good to go!
>
> Jarek, thanks for patch OPENEJB-562! Applying it now. Any chance
> you'll be able to do the JAX-WS version of the JAX-RPC test case?
> Manu and/or some else might be able to help get that running too.
> Let us know what your thoughts are.
>
> Thanks,
> David
>
>
> > Regards
> > Manu
> >
> > On 4/17/07, Jacek Laskowski <ja...@laskowski.net.pl> wrote:
> >> On 4/16/07, Manu George <ma...@gmail.com> wrote:
> >> > I would like to volunteer for this task :). Anyone else
> >> interested to join me ?
> >>
> >> I'll surely be watching your steps, but can't commit any time on it
> >> yet. I'd like to throw some fresh air to the assembly module.
> >>
> >> Jacek
> >>
> >> --
> >> Jacek Laskowski
> >> http://www.JacekLaskowski.pl
> >>
> >
>
>
Re: Web Service Provider and OpenEJB integration (was: Re: jaxrpc ejb web services support in Geronimo)
Posted by David Blevins <da...@visi.com>.
On Apr 17, 2007, at 11:51 AM, Manu George wrote:
> Hi,
> I just attached a patch to
> https://issues.apache.org/jira/browse/OPENEJB-563. Its something i put
> together fast. It works (Test Case runs fine). David can you give it a
> look and point out any issues.
Looks great, Manu!
Couple thoughts I had. We should be able to set the MessageContext
in the ThreadContext in container's "if (isWebService...)" block
which would eliminate the large chunk that seems to do it in the
ReflectionInvocationContext. As far as the parameters go I totally
forgot to add an assertEquals to verify the bean gets "Hello World"
as the arg and is able to return it. We should definitely add that.
Feel free to check it in as is then update or update it then check it
in, whatever you like. It's good to go!
Jarek, thanks for patch OPENEJB-562! Applying it now. Any chance
you'll be able to do the JAX-WS version of the JAX-RPC test case?
Manu and/or some else might be able to help get that running too.
Let us know what your thoughts are.
Thanks,
David
> Regards
> Manu
>
> On 4/17/07, Jacek Laskowski <ja...@laskowski.net.pl> wrote:
>> On 4/16/07, Manu George <ma...@gmail.com> wrote:
>> > I would like to volunteer for this task :). Anyone else
>> interested to join me ?
>>
>> I'll surely be watching your steps, but can't commit any time on it
>> yet. I'd like to throw some fresh air to the assembly module.
>>
>> Jacek
>>
>> --
>> Jacek Laskowski
>> http://www.JacekLaskowski.pl
>>
>
Re: Web Service Provider and OpenEJB integration (was: Re: jaxrpc ejb web services support in Geronimo)
Posted by Manu George <ma...@gmail.com>.
Hi,
I just attached a patch to
https://issues.apache.org/jira/browse/OPENEJB-563. Its something i put
together fast. It works (Test Case runs fine). David can you give it a
look and point out any issues.
Regards
Manu
On 4/17/07, Jacek Laskowski <ja...@laskowski.net.pl> wrote:
> On 4/16/07, Manu George <ma...@gmail.com> wrote:
> > I would like to volunteer for this task :). Anyone else interested to join me ?
>
> I'll surely be watching your steps, but can't commit any time on it
> yet. I'd like to throw some fresh air to the assembly module.
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.JacekLaskowski.pl
>
Re: Web Service Provider and OpenEJB integration (was: Re: jaxrpc ejb web services support in Geronimo)
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 4/16/07, Manu George <ma...@gmail.com> wrote:
> I would like to volunteer for this task :). Anyone else interested to join me ?
I'll surely be watching your steps, but can't commit any time on it
yet. I'd like to throw some fresh air to the assembly module.
Jacek
--
Jacek Laskowski
http://www.JacekLaskowski.pl
Re: Web Service Provider and OpenEJB integration (was: Re: jaxrpc ejb web services support in Geronimo)
Posted by Manu George <ma...@gmail.com>.
I would like to volunteer for this task :). Anyone else interested to join me ?
Regards
Manu
On 4/14/07, David Blevins <da...@visi.com> wrote:
> I personally don't have time to fix these as I'm swamped with the
> business interface proxy changes. Between OpenEJB and Geronimo, I'm
> pretty much the only guy who understands how it was all integrated in
> 2x and how that maps into 3x. Since that's generally not a good
> thing, i've done my absolute best to come up with a test case that
> documents all the details on how a Web Service Provider and OpenEJB
> would come together to complete the EJB Web Services puzzle. At
> least how it relates to JAX-RPC.
>
> Here is that test case (not that the test method is more or less
> commented out):
>
> http://svn.apache.org/repos/asf/incubator/openejb/trunk/openejb3/
> container/openejb-core/src/test/java/org/apache/openejb/core/
> stateless/JaxRpcWebServiceInvocationTest.java
>
> There's some code in there already to perform the OpenEJB side of
> this, but as Jarek points out it still has issues. Are there any
> adventurous souls out there who'd like to try and get this working?
> Multiple volunteers are welcome, as always.
>
> Jarek, is it possible you can use this test case and craft up a
> simlilar one for JAX-WS Web Service invocations? It'll probably take
> some discussion on how we want those to work as we've never done JAX-
> WS whereas in 2x we at least had a certified JAX-RPC integration to
> work from.
>
>
> -David
>
>
> On Apr 12, 2007, at 10:28 PM, Jarek Gawor wrote:
>
> > Hi folks,
> >
> > I'm working on getting jaxrpc ejb support working again in Geronimo.
> > I believe I have everything setup ok in Geronimo and now I'm running
> > into the following problems in OpenEJB:
> >
> > 1) In org.apache.openejb.core.stateless.StatelessContainer the
> > isWebServiceCall() function returns false because the
> > deployment.getServiceEndpointInterface() function returns null. But I
> > think the getServiceEndpointInterfaceName() returns a non null value
> > (service endpoint interface is set in the DD).
> >
> > 2) If 1) is fixed then I see
> > org.apache.openejb.core.interceptor.ReflectionInvocationContext.procee
> > d()
> > function raise "Parameters have not been set" exception. The the
> > jaxrpc interceptor (in
> > org.apache.openejb.server.axis.EjbContainerProvider) is supposed to
> > set the parameters but the parameters check in
> > ReflectionInvocationContext.proceed() is done before the interceptors
> > are invoked.
> >
> > 3) And if 2) if fixed then the jaxrpc interceptor is not getting
> > invoked at all. I'm not sure what's going on with that.
> >
> > I have a test case in Geronimo code base to test this integration (in
> > 'testsuite/webservices-testsuite/jaxrpc-tests/jaxrpc-ejb" directory).
> > Both
> > "testInvocation" and "testWSDL" tests should pass (the "testEJB" test
> > case always fails so can be ignored for now).
> >
> > I would appreciate if somebody could fix or take a closer look at
> > these problems.
> >
> > Let me know if you have any questions, etc.
> >
> > Thanks,
> > Jarek
> >
>
>
Web Service Provider and OpenEJB integration (was: Re: jaxrpc ejb web services support in Geronimo)
Posted by David Blevins <da...@visi.com>.
I personally don't have time to fix these as I'm swamped with the
business interface proxy changes. Between OpenEJB and Geronimo, I'm
pretty much the only guy who understands how it was all integrated in
2x and how that maps into 3x. Since that's generally not a good
thing, i've done my absolute best to come up with a test case that
documents all the details on how a Web Service Provider and OpenEJB
would come together to complete the EJB Web Services puzzle. At
least how it relates to JAX-RPC.
Here is that test case (not that the test method is more or less
commented out):
http://svn.apache.org/repos/asf/incubator/openejb/trunk/openejb3/
container/openejb-core/src/test/java/org/apache/openejb/core/
stateless/JaxRpcWebServiceInvocationTest.java
There's some code in there already to perform the OpenEJB side of
this, but as Jarek points out it still has issues. Are there any
adventurous souls out there who'd like to try and get this working?
Multiple volunteers are welcome, as always.
Jarek, is it possible you can use this test case and craft up a
simlilar one for JAX-WS Web Service invocations? It'll probably take
some discussion on how we want those to work as we've never done JAX-
WS whereas in 2x we at least had a certified JAX-RPC integration to
work from.
-David
On Apr 12, 2007, at 10:28 PM, Jarek Gawor wrote:
> Hi folks,
>
> I'm working on getting jaxrpc ejb support working again in Geronimo.
> I believe I have everything setup ok in Geronimo and now I'm running
> into the following problems in OpenEJB:
>
> 1) In org.apache.openejb.core.stateless.StatelessContainer the
> isWebServiceCall() function returns false because the
> deployment.getServiceEndpointInterface() function returns null. But I
> think the getServiceEndpointInterfaceName() returns a non null value
> (service endpoint interface is set in the DD).
>
> 2) If 1) is fixed then I see
> org.apache.openejb.core.interceptor.ReflectionInvocationContext.procee
> d()
> function raise "Parameters have not been set" exception. The the
> jaxrpc interceptor (in
> org.apache.openejb.server.axis.EjbContainerProvider) is supposed to
> set the parameters but the parameters check in
> ReflectionInvocationContext.proceed() is done before the interceptors
> are invoked.
>
> 3) And if 2) if fixed then the jaxrpc interceptor is not getting
> invoked at all. I'm not sure what's going on with that.
>
> I have a test case in Geronimo code base to test this integration (in
> 'testsuite/webservices-testsuite/jaxrpc-tests/jaxrpc-ejb" directory).
> Both
> "testInvocation" and "testWSDL" tests should pass (the "testEJB" test
> case always fails so can be ignored for now).
>
> I would appreciate if somebody could fix or take a closer look at
> these problems.
>
> Let me know if you have any questions, etc.
>
> Thanks,
> Jarek
>