[jira] [Resolved] (CASSANDRA-10215) Reduce redundant secondary index selection lookups

["Sam Tunnicliffe (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sam Tunnicliffe resolved CASSANDRA-10215.
-----------------------------------------
    Resolution: Fixed

Thanks, I've added more detail to the logged error message, rebased, squashed & committed to 3.0 in {{e097efc5f6f76a0da8d15b307301dffff79e4a35}}. dtest pr [here|https://github.com/riptano/cassandra-dtest/pull/538] 

Just as a note, the unit test failures are all timeouts and seem to have been caused by setting the default back to 60s ([f961e84|https://github.com/apache/cassandra/commit/f961e84aa6fc139d7227e96b562e76ab857aaad0]). An almost identical set of failures was reported on cassci's most recent [3.0|http://cassci.datastax.com/view/cassandra-3.0/job/cassandra-3.0_testall/113/testReport/] & [trunk|http://cassci.datastax.com/view/trunk/job/trunk_testall/409/testReport/] runs. The dtests are slightly harder to compare, due to a bug in the test framework, fixed in [51ef2e4|https://github.com/riptano/cassandra-dtest/commit/51ef2e4113cc71e6a526143644d89a2e4d2bebfc] before the latest run of my branch, but after the last 3.0/trunk runs. It doesn't look to me like any of the remaining dtest failures on the branch are related to this patch.

CI Tests:
* [3.0 testall|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10215-3.0-testall/]
* [3.0 dtest|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10215-3.0-dtest/]
* [trunk testall|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10215-trunk-testall/]
* [trunk dtest|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10215-trunk-dtest/]


> Reduce redundant secondary index selection lookups
> --------------------------------------------------
>
>                 Key: CASSANDRA-10215
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10215
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>             Fix For: 3.0.0 rc1
>
>
> Once an index has been identified as being the one that should be used for a given query, it should be included as part of the {{ReadCommand}} so that it can be retrieved when needed during execution. Currently we don't do this, meaning that the index selection process implemented in {{SIM::getBestIndexFor}} is run multiple times on both the coordinator and each replica when performing a range command.
> This is also a pre-requisite of CASSANDRA-10214



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)