You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/27 16:59:20 UTC

[GitHub] [airflow] edithturn opened a new pull request #21161: added selective ci checks py

edithturn opened a new pull request #21161:
URL: https://github.com/apache/airflow/pull/21161


   **Rewrite selective check script in Python**
   
   01. .github/workflows/build-images.yml and .github/workflows/ci.yaml they are calling the step: **Selective checks** airflow/scripts/ci/selective_ci_checks.sh wich we are writing in python
   
   
         - name: Selective checks
           id: selective-checks
           env:
             PR_LABELS: ${{ steps.get-latest-pr-labels.outputs.pullRequestLabels }}
           run: |
             if [[ ${GITHUB_EVENT_NAME} == "pull_request_target" ]]; then
               # Run selective checks
               ./scripts/ci/selective_ci_checks.sh "${TARGET_COMMIT_SHA}"
             else
               # Run all checks
               ./scripts/ci/selective_ci_checks.sh
             fi
   Close: #19971 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn edited a comment on pull request #21161: added selective ci checks py

Posted by GitBox <gi...@apache.org>.
edithturn edited a comment on pull request #21161:
URL: https://github.com/apache/airflow/pull/21161#issuecomment-1030359748


   @potiuk, could you please guide me in this part, I am trying to call it as a subprocess but I think it is incorrect.
   https://github.com/apache/airflow/blob/ec41fd51e07ca2b9a66e0b99b730300c80a6d059/scripts/ci/selective_ci_checks.sh#L58-L60
   
   Nore: I uninstall pre commits just to let me push this part of the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #21161: added selective ci checks py

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21161:
URL: https://github.com/apache/airflow/pull/21161#issuecomment-1030911273


   Maybe we can have a talk about it :) ? Happy to guide you on 1-1 call.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn closed pull request #21161: added selective ci checks py

Posted by GitBox <gi...@apache.org>.
edithturn closed pull request #21161:
URL: https://github.com/apache/airflow/pull/21161


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn closed pull request #21161: added selective ci checks py

Posted by GitBox <gi...@apache.org>.
edithturn closed pull request #21161:
URL: https://github.com/apache/airflow/pull/21161


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn commented on pull request #21161: added selective ci checks py

Posted by GitBox <gi...@apache.org>.
edithturn commented on pull request #21161:
URL: https://github.com/apache/airflow/pull/21161#issuecomment-1030359748


   @potiuk, could you please guide me in this part, I am trying to call it as a subprocess but I think it is incorrect.
   https://github.com/apache/airflow/blob/ec41fd51e07ca2b9a66e0b99b730300c80a6d059/scripts/ci/selective_ci_checks.sh#L58-L60


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org