Re: [PR] [SPARK-45715][CORE] QueryPlanningTracker::measurePhase minor refactor [spark]

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #43570:
URL: https://github.com/apache/spark/pull/43570#discussion_r1375228459


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/QueryPlanningTracker.scala:
##########
@@ -134,7 +134,7 @@ class QueryPlanningTracker(
    * and the recorded end time will be the end time of the last call.
    */
   def measurePhase[T](phase: String)(f: => T): T = {
-    val startTime = System.currentTimeMillis()
+    val startTime = System.currentTimeMillis

Review Comment:
   Is this a known compilation error that will be triggered in Scala 3? Or is it an existing compilation warning in Scala 2.13? If not, I don't think it's worth fixing it just for the sake of maintaining consistency in call style.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org