[jira] [Commented] (CASSANDRA-15564) Refactor repair coordinator so errors are consistent

["David Capwell (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036640#comment-17036640 ] 

David Capwell commented on CASSANDRA-15564:
-------------------------------------------

[~spod] I finally was able to split the refactor into its own branch.  The size of this is mostly to enable the ability to test; the test code is more than twice as large as src/java, so not as scary as it looks.

{code}
$ git diff trunk src/java/ | wc -l
     730
$ git diff trunk test/ | wc -l
    1670
{code}

[~ifesdjeen] [~yifanc] made changes to dtest you should be aware of: nodetool now captures all events, and message filters runs inbound

> Refactor repair coordinator so errors are consistent
> ----------------------------------------------------
>
>                 Key: CASSANDRA-15564
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15564
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Consistency/Repair
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is to split the change in CASSANDRA-15399 so the refactor is isolated out.
> Currently the repair coordinator special cases the exit cases at each call site; this makes it so that errors can be inconsistent and there are cases where proper complete isn't done (proper notifications, and forgetting to update ActiveRepairService).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org