[GitHub] [spark] MaxGekk commented on a diff in pull request #39018: [SPARK-41478][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1234

[GitBox <gi...@apache.org>]

MaxGekk commented on code in PR #39018:
URL: https://github.com/apache/spark/pull/39018#discussion_r1045690227


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1257,6 +1257,11 @@
           "AES-<mode> with the padding <padding> by the <functionName> function."
         ]
       },
+      "ANALYZE_TABLE_VIEW_NOT_CACHED" : {
+        "message" : [
+          "Temporary view <tableName> is not cached for analyzing columns."

Review Comment:
   Could you improve the error message by following the common structure as in other errors in `error-classes.json`:
   1. State the issue
   2. Give a suggestion how to solve it.
   
   The error could be:
   ```suggestion
             "The ANALYZE TABLE FOR COLUMNS command can operate on temporary views that have been cached already. Consider to cache the view <view Name>."
   ```



##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1257,6 +1257,11 @@
           "AES-<mode> with the padding <padding> by the <functionName> function."
         ]
       },
+      "ANALYZE_TABLE_VIEW_NOT_CACHED" : {

Review Comment:
   ```suggestion
         "ANALYZE_UNCACHED_TEMP_VIEW" : {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org