You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/16 04:56:07 UTC
[GitHub] [shardingsphere] azexcy opened a new pull request, #22905: Fix occasional ci error at InventoryTaskTest
azexcy opened a new pull request, #22905:
URL: https://github.com/apache/shardingsphere/pull/22905
Changes proposed in this pull request:
- Fix occasional ci error at InventoryTaskTest
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on a diff in pull request #22905: Fix occasional ci error at InventoryTaskTest
Posted by GitBox <gi...@apache.org>.
azexcy commented on code in PR #22905:
URL: https://github.com/apache/shardingsphere/pull/22905#discussion_r1050407518
##########
test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/task/InventoryTaskTest.java:
##########
@@ -77,7 +76,7 @@ public void assertStartWithGetEstimatedRowsFailure() throws ExecutionException,
PipelineTableMetaDataLoader metaDataLoader = new StandardPipelineTableMetaDataLoader(dataSource);
try (
InventoryTask inventoryTask = new InventoryTask(inventoryDumperConfig, taskConfig.getImporterConfig(),
- PipelineContextUtil.getPipelineChannelCreator(), new DataSourceImporterConnector(DATA_SOURCE_MANAGER), dataSource,
Review Comment:
TODO, In concurrent scenarios, importer may not stop causing ci timeout, I will follow up on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #22905: Fix occasional ci error at InventoryTaskTest
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #22905:
URL: https://github.com/apache/shardingsphere/pull/22905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on pull request #22905: Fix occasional ci error at InventoryTaskTest
Posted by GitBox <gi...@apache.org>.
azexcy commented on PR #22905:
URL: https://github.com/apache/shardingsphere/pull/22905#issuecomment-1354278997
TODO, In concurrent scenarios, importer may not stop causing ci timeout, I will follow up on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on pull request #22905: Fix occasional ci error at InventoryTaskTest
Posted by GitBox <gi...@apache.org>.
azexcy commented on PR #22905:
URL: https://github.com/apache/shardingsphere/pull/22905#issuecomment-1354229878
I trigger the ci at my forked repository, it's passed
<img width="991" alt="image" src="https://user-images.githubusercontent.com/101622833/208027756-0c108106-3b00-486d-8e30-adf8882f0707.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org