You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2015/12/04 23:21:13 UTC

Review Request 40992: Ranger-767: Refactor UserGroupSink implementation and consolidate performance improvements

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40992/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.


Bugs: Ranger-767
    https://issues.apache.org/jira/browse/Ranger-767


Repository: ranger


Description
-------

Refactored org.apache.ranger.ldapusersync.process.PolicyMgrUserGroupBuilder to extend from org.apache.ranger.unixusersync.process.PolicyMgrUserGroupBuilder in order to remove code duplication and support backward compatibility


Diffs
-----

  ugsync/src/main/java/org/apache/ranger/ldapusersync/process/PolicyMgrUserGroupBuilder.java c99f7a0 

Diff: https://reviews.apache.org/r/40992/diff/


Testing
-------

1. Changed user sync configuration by setting ranger.usersync.sink.impl.class=org.apache.ranger.ldapusersync.process.PolicyMgrUserGroupBuilder and ran tests to sync 5000 users from AD.
2. Changed user sync configuration by setting ranger.usersync.sink.impl.class=org.apache.ranger.unixusersync.process.PolicyMgrUserGroupBuilder and ran tests to sync 5000 users from AD and noticed the same results as test case 1.


Thanks,

Sailaja Polavarapu