[GitHub] [incubator-superset] ktmud edited a comment on pull request #11883: refactor: move enums to the beginning of utils/core.py

[GitBox <gi...@apache.org>]

ktmud edited a comment on pull request #11883:
URL: https://github.com/apache/incubator-superset/pull/11883#issuecomment-737385876


   > Would now be a good time to move these to a separate file, like `superset/types.py`? I would also consolidate the aliases from `superset/typing.py` into the new file, as that name clashes with the builtin `typing`.
   
   Do we consider enums part of typing? I thought they are constants as well.
   
   Was debating internally whether to move them into `superset.constants`, but kind of also feel for less general enums, they should probably be put locally into each submodule. It's a hard choice, so I went with the easiest and smallest change...
   
   Either way, we should definitely find ways to break up the thousand-LOC `core.py` files.
   
   Could you clarify how does `superset.typing` clash with the builtin `typing`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org