You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/08/15 03:25:33 UTC
[GitHub] [hudi] watermelon12138 opened a new pull request, #6395: [HUDI-4620] No expected exception is thrown when create hudi table without primaryKey
watermelon12138 opened a new pull request, #6395:
URL: https://github.com/apache/hudi/pull/6395
### Change Logs
No expected exception is thrown when create hudi table without primaryKey.
Expected exception:
“java.lang.IllegalArgumentException: No `primaryKey` is specified."
Thrown exception now:
“Can't find primaryKey `uuid` in root”
### Impact
_Describe any public API or user-facing feature change or any performance impact._
**Risk level: none | low | medium | high**
_Choose one. If medium or high, explain what verification was done to mitigate the risks._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua closed pull request #6395: [HUDI-4620] No expected exception is thrown when create hudi table without primaryKey
Posted by GitBox <gi...@apache.org>.
yihua closed pull request #6395: [HUDI-4620] No expected exception is thrown when create hudi table without primaryKey
URL: https://github.com/apache/hudi/pull/6395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6395: [HUDI-4620] No expected exception is thrown when create hudi table without primaryKey
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6395:
URL: https://github.com/apache/hudi/pull/6395#issuecomment-1214590925
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "952bef85e137b87f1a24a08eb71d987e53a6460b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10762",
"triggerID" : "952bef85e137b87f1a24a08eb71d987e53a6460b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 952bef85e137b87f1a24a08eb71d987e53a6460b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10762)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6395: [HUDI-4620] No expected exception is thrown when create hudi table without primaryKey
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6395:
URL: https://github.com/apache/hudi/pull/6395#issuecomment-1214654472
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "952bef85e137b87f1a24a08eb71d987e53a6460b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10762",
"triggerID" : "952bef85e137b87f1a24a08eb71d987e53a6460b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 952bef85e137b87f1a24a08eb71d987e53a6460b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10762)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6395: [HUDI-4620] No expected exception is thrown when create hudi table without primaryKey
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6395:
URL: https://github.com/apache/hudi/pull/6395#issuecomment-1214588163
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "952bef85e137b87f1a24a08eb71d987e53a6460b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "952bef85e137b87f1a24a08eb71d987e53a6460b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 952bef85e137b87f1a24a08eb71d987e53a6460b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #6395: [HUDI-4620] No expected exception is thrown when create hudi table without primaryKey
Posted by GitBox <gi...@apache.org>.
yihua commented on code in PR #6395:
URL: https://github.com/apache/hudi/pull/6395#discussion_r964134956
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieOptionConfig.scala:
##########
@@ -46,7 +46,6 @@ object HoodieOptionConfig {
.withSqlKey("primaryKey")
.withHoodieKey(DataSourceWriteOptions.RECORDKEY_FIELD.key)
.withTableConfigKey(HoodieTableConfig.RECORDKEY_FIELDS.key)
- .defaultValue(DataSourceWriteOptions.RECORDKEY_FIELD.defaultValue())
Review Comment:
Shall we also remove the default value in `KeyGeneratorOptions` so that Spark SQL has consistent behavior with Spark datasource?
```
public static final ConfigProperty<String> RECORDKEY_FIELD_NAME = ConfigProperty
.key("hoodie.datasource.write.recordkey.field")
.defaultValue("uuid")
.withDocumentation("Record key field. Value to be used as the `recordKey` component of `HoodieKey`.\n"
+ "Actual value will be obtained by invoking .toString() on the field value. Nested fields can be specified using\n"
+ "the dot notation eg: `a.b.c`");
```
cc @YannByron @nsivabalan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #6395: [HUDI-4620] No expected exception is thrown when create hudi table without primaryKey
Posted by GitBox <gi...@apache.org>.
yihua commented on code in PR #6395:
URL: https://github.com/apache/hudi/pull/6395#discussion_r970068956
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieOptionConfig.scala:
##########
@@ -46,7 +46,6 @@ object HoodieOptionConfig {
.withSqlKey("primaryKey")
.withHoodieKey(DataSourceWriteOptions.RECORDKEY_FIELD.key)
.withTableConfigKey(HoodieTableConfig.RECORDKEY_FIELDS.key)
- .defaultValue(DataSourceWriteOptions.RECORDKEY_FIELD.defaultValue())
Review Comment:
Hi @watermelon12138, I just noticed that this change is already covered by #5771. I'll close this one as a duplicate. Feel free to review the other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org