You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/31 14:43:33 UTC

[GitHub] [superset] simcha90 commented on pull request #12199: feat(native-filters): Add defaultValue for Native filters modal

simcha90 commented on pull request #12199:
URL: https://github.com/apache/superset/pull/12199#issuecomment-770392908


   @junlincc Hi fixed your notes (about 3. it works for me, but may it was fixed by my other changes).
   I also needed update some part of code to cause `Reset All` work, so I also updated description of PR with all changes
   
   About multiple values, it can be good idea but I think in other PR in order to not increase size of this one, because implementing of this feature caused some cascading changes in other parts of code, so it have now XL size :)
   
   cc @villebro 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org