[GitHub] [geode] jinmeiliao commented on pull request #7697: GEODE-10304: locator thread should not exit after reconnecting

[GitBox <gi...@apache.org>]

jinmeiliao commented on PR #7697:
URL: https://github.com/apache/geode/pull/7697#issuecomment-1145549256

   > I'm not sure what changes here were actually necessary to fix the bug. In general, I would recommend either making just the minimal change to fix the bug or do a more sweeting fixup of the test (ie, getting rid of all catch blocks, use ErrorCollector for anything that's an async callback if those exist, convert all JUnit Asserts and Hamcrest usages to AssertJ, etc). Either way, you should call out which lines actually fix the bug.
   > 
   > You might also consider stating if this fixes a product bug or a flaky test. `GEODE-10304: locator thread should not exit after reconnecting` makes it sound like you're fixing a product bug.
   
   The only product change is the change I made in `InternalLocator`. The changes in the test are just using lamda to replace `Callable` and `Runnable` interfaces. I will update the comment to reflect that.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org