You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/01/26 10:01:40 UTC

[GitHub] sijie commented on a change in pull request #3432: [Issue 3431] Support Kafka-IO to pass extra configs

sijie commented on a change in pull request #3432: [Issue 3431] Support Kafka-IO to pass extra configs
URL: https://github.com/apache/pulsar/pull/3432#discussion_r251194474
 
 

 ##########
 File path: site2/docs/io-kafka.md
 ##########
 @@ -37,5 +38,6 @@ to a Kafka topic.
 | batchSize | `true` | `null` | The kafka producer batch size. |
 | maxRequestSize | `true` | `null` | The maximum size of a request in bytes. |
 | topic | `true` | `null` | Topic name to receive records from Kafka |
+| producerConfigPropertiesFile | `false` | `null` | The producer config properties file containing configs to be passed to Producer. |
 
 Review comment:
   can you document how the settings are applied? for example, if I specify max.request.size in producer properties file, and in maxRequestSize in the connector config file, which one is taking effects?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services