You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ben Collins-Sussman <su...@collab.net> on 2002/07/17 17:30:02 UTC

Re: svn commit: rev 2570 - trunk/subversion/tests/clients/cmdline

Wow, this is an embarrassment.  :-)

I was in the middle of writing a new commit-test in utf8_tests.py, and
forgot to give the 'wc_dir' argument to run_svn('commit'...).  So it
actually performed a real commit in '.'... and here's my half-written
utf8_tests.py.  :-)

Anyway, no need to revert.  It's not like anyone or anything is
running this python script yet.


sussman@tigris.org writes:

> Author: sussman
> Date: Wed, 17 Jul 2002 12:09:34 -0500
> New Revision: 2570
> 
> Modified:
>    trunk/subversion/tests/clients/cmdline/utf8_tests.py
> Log:
> drie\303\253ntwintig keer was \303\251\303\251n keer teveel
> 
> Modified: trunk/subversion/tests/clients/cmdline/utf8_tests.py
> ==============================================================================
> --- trunk/subversion/tests/clients/cmdline/utf8_tests.py	(original)
> +++ trunk/subversion/tests/clients/cmdline/utf8_tests.py	Wed Jul 17 12:09:39 2002
> @@ -17,7 +17,7 @@
>  ######################################################################
>  
>  # General modules
> -import shutil, stat, string, sys, re, os.path
> +import shutil, stat, string, sys, re, os.path, os
>  
>  # Our testing module
>  import svntest
> @@ -56,27 +56,17 @@
>    svntest.main.file_append(os.path.join(wc_dir, i18n_filename), "hi")
>    svntest.main.run_svn(None, 'add', os.path.join(wc_dir, i18n_filename))
>  
> -  # Created expected output tree for 'svn ci'
> -  expected_output = wc.State(wc_dir, {
> -    i18n_filename : Item(verb='Adding'),
> -    })
> -
> -  # Create expected status tree; all local revisions should be at 1,
> -  # but the new file should be at revision 2.
> -  expected_status = svntest.actions.get_virginal_state(wc_dir, 2)
> -  expected_status.tweak(wc_rev=1)
> -  expected_status.add({
> -    i18n_filename : Item(status='_ ', wc_rev=2, repos_rev=2),
> -    })
> -
> -  return svntest.actions.run_and_verify_commit (wc_dir,
> -                                                expected_output,
> -                                                expected_status,
> -                                                None,
> -                                                None, None,
> -                                                None, None,
> -                                                wc_dir)
> -  
> +  # Set our environment's locale to ISO-8859-1
> +  os.putenv('LC_ALL', 'ISO-8859-1')
> +
> +  outlines, inlines = svntest.main.run_svn(None, # no error expected
> +                                           'commit', '-m', i18n_logmsg)
> +  if errlines:
> +    return 1
> +
> +
> +  return 0
> +
>  # Here's how the test should really work:
>  
>  # 1. sh LC_ALL=ISO-8859-1 svn commit <filename> -m "<logmsg>"
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org