You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/22 06:48:49 UTC

[GitHub] [beam] hengfengli opened a new pull request, #17443: [BEAM-12164]: use the end timestamp for progress estimation in batch jobs

hengfengli opened a new pull request, #17443:
URL: https://github.com/apache/beam/pull/17443

   The logic of the progress calculation: 
   
   * If the end timestamp is specified, then use it to estimate the remaining work via `endTimestamp - lastClaimedPosition`. 
   * Otherwise, use `now() - lastClaimedPosition` as the remaining work. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #17443: [BEAM-12164]: use the end timestamp for progress estimation in batch jobs

Posted by GitBox <gi...@apache.org>.
pabloem merged PR #17443:
URL: https://github.com/apache/beam/pull/17443


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17443: [BEAM-12164]: use the end timestamp for progress estimation in batch jobs

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17443:
URL: https://github.com/apache/beam/pull/17443#issuecomment-1106069078

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17443: [BEAM-12164]: use the end timestamp for progress estimation in batch jobs

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17443:
URL: https://github.com/apache/beam/pull/17443#issuecomment-1106069080

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] hengfengli commented on pull request #17443: [BEAM-12164]: use the end timestamp for progress estimation in batch jobs

Posted by GitBox <gi...@apache.org>.
hengfengli commented on PR #17443:
URL: https://github.com/apache/beam/pull/17443#issuecomment-1110469217

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #17443: [BEAM-12164]: use the end timestamp for progress estimation in batch jobs

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17443:
URL: https://github.com/apache/beam/pull/17443#issuecomment-1111758349

   there's a test failure that seems related: https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/22353/testReport/junit/org.apache.beam.sdk.io.gcp.spanner.changestreams.restriction/TimestampRangeTrackerTest/testGetProgressForStreaming/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #17443: [BEAM-12164]: use the end timestamp for progress estimation in batch jobs

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17443:
URL: https://github.com/apache/beam/pull/17443#issuecomment-1112905116

   LGTM. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] thiagotnunes commented on pull request #17443: [BEAM-12164]: use the end timestamp for progress estimation in batch jobs

Posted by GitBox <gi...@apache.org>.
thiagotnunes commented on PR #17443:
URL: https://github.com/apache/beam/pull/17443#issuecomment-1112773907

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17443: [BEAM-12164]: use the end timestamp for progress estimation in batch jobs

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17443:
URL: https://github.com/apache/beam/pull/17443#issuecomment-1106069077

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org