You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ankita Sinha <an...@freestoneinfotech.com> on 2017/02/13 10:09:20 UTC

Review Request 56590: Good coding practice for concurrent modification

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56590/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1379
    https://issues.apache.org/jira/browse/RANGER-1379


Repository: ranger


Description
-------

Good coding practice for concurrent modification while checking for request is from browser


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java daf3c8e 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java 36a0fa3 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java d10fc46 
  security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8cd26a6 

Diff: https://reviews.apache.org/r/56590/diff/


Testing
-------

1. Tested on simple cluster with plugins and Ranger KMS
2. Tested on secure cluster with plugins and Ranger KMS


Thanks,

Ankita Sinha


Re: Review Request 56590: Good coding practice for concurrent modification

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56590/#review165491
-----------------------------------------------------------


Ship it!




Ship It!

- Gautam Borad


On Feb. 13, 2017, 10:09 a.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56590/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 10:09 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1379
>     https://issues.apache.org/jira/browse/RANGER-1379
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Good coding practice for concurrent modification while checking for request is from browser
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java daf3c8e 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java 36a0fa3 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java d10fc46 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8cd26a6 
> 
> Diff: https://reviews.apache.org/r/56590/diff/
> 
> 
> Testing
> -------
> 
> 1. Tested on simple cluster with plugins and Ranger KMS
> 2. Tested on secure cluster with plugins and Ranger KMS
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>


Re: Review Request 56590: Good coding practice for concurrent modification

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56590/#review165488
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Feb. 13, 2017, 10:09 a.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56590/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 10:09 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1379
>     https://issues.apache.org/jira/browse/RANGER-1379
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Good coding practice for concurrent modification while checking for request is from browser
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java daf3c8e 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java 36a0fa3 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java d10fc46 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8cd26a6 
> 
> Diff: https://reviews.apache.org/r/56590/diff/
> 
> 
> Testing
> -------
> 
> 1. Tested on simple cluster with plugins and Ranger KMS
> 2. Tested on secure cluster with plugins and Ranger KMS
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>