You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "showuon (via GitHub)" <gi...@apache.org> on 2023/04/06 02:58:07 UTC
[GitHub] [kafka] showuon commented on a diff in pull request #13459: KAFKA-14592: Move FeatureCommand to tools
showuon commented on code in PR #13459:
URL: https://github.com/apache/kafka/pull/13459#discussion_r1159227186
##########
tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java:
##########
@@ -0,0 +1,331 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kafka.tools;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Properties;
+import java.util.TreeSet;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.stream.Collectors;
+import net.sourceforge.argparse4j.ArgumentParsers;
+import net.sourceforge.argparse4j.impl.Arguments;
+import net.sourceforge.argparse4j.inf.ArgumentParser;
+import net.sourceforge.argparse4j.inf.Namespace;
+import net.sourceforge.argparse4j.inf.Subparser;
+import net.sourceforge.argparse4j.inf.Subparsers;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.FeatureMetadata;
+import org.apache.kafka.clients.admin.FeatureUpdate;
+import org.apache.kafka.clients.admin.SupportedVersionRange;
+import org.apache.kafka.clients.admin.UpdateFeaturesOptions;
+import org.apache.kafka.clients.admin.UpdateFeaturesResult;
+import org.apache.kafka.common.utils.Exit;
+import org.apache.kafka.common.utils.Utils;
+import org.apache.kafka.server.common.MetadataVersion;
+
+import static net.sourceforge.argparse4j.impl.Arguments.append;
+import static net.sourceforge.argparse4j.impl.Arguments.store;
+import static net.sourceforge.argparse4j.impl.Arguments.storeTrue;
+
+public class FeatureCommand {
+ public static void main(String... args) {
+ Exit.exit(mainNoExit(args));
+ }
+
+ static int mainNoExit(String... args) {
+ try {
+ execute(args);
+ return 0;
+ } catch (TerseException e) {
+ System.err.println(e.getMessage());
+ return 1;
+ } catch (Throwable e) {
+ System.err.println(e.getMessage());
+ System.err.println(Utils.stackTrace(e));
+ return 1;
+ }
+ }
+
+ static void execute(String... args) throws Exception {
+ ArgumentParser parser = ArgumentParsers
+ .newArgumentParser("kafka-features")
+ .defaultHelp(true)
+ .description("This tool manages feature flags in Kafka.");
+ parser
+ .addArgument("--bootstrap-server")
+ .help("A comma-separated list of host:port pairs to use for establishing the connection to the Kafka cluster.")
+ .required(true);
+
+ parser
+ .addArgument("--command-config")
+ .type(Arguments.fileType())
+ .help("Property file containing configs to be passed to Admin Client.");
+ Subparsers subparsers = parser.addSubparsers().dest("command");
+ addDescribeParser(subparsers);
+ addUpgradeParser(subparsers);
+ addDowngradeParser(subparsers);
+ addDisableParser(subparsers);
+
+ Namespace namespace = parser.parseArgsOrFail(args);
+ String command = namespace.getString("command");
+ String configPath = namespace.getString("command_config");
+ Properties properties = (configPath == null) ? new Properties() : Utils.loadProps(configPath);
+
+ String bootstrapServer = namespace.getString("bootstrap_server");
+ if (bootstrapServer != null) {
+ properties.setProperty("bootstrap.servers", bootstrapServer);
+ }
+ if (properties.getProperty("bootstrap.servers") == null) {
+ throw new TerseException("Please specify --bootstrap-server.");
+ }
+
+ switch (command) {
+ case "describe": {
+ try (Admin adminClient = Admin.create(properties)) {
Review Comment:
Maybe we can move this admin creation up before switch case line to avoid duplicated code, ex:
```
try (Admin adminClient = Admin.create(properties)) {
switch (command)
...
}
```
##########
tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java:
##########
@@ -0,0 +1,331 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kafka.tools;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Properties;
+import java.util.TreeSet;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.stream.Collectors;
+import net.sourceforge.argparse4j.ArgumentParsers;
+import net.sourceforge.argparse4j.impl.Arguments;
+import net.sourceforge.argparse4j.inf.ArgumentParser;
+import net.sourceforge.argparse4j.inf.Namespace;
+import net.sourceforge.argparse4j.inf.Subparser;
+import net.sourceforge.argparse4j.inf.Subparsers;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.FeatureMetadata;
+import org.apache.kafka.clients.admin.FeatureUpdate;
+import org.apache.kafka.clients.admin.SupportedVersionRange;
+import org.apache.kafka.clients.admin.UpdateFeaturesOptions;
+import org.apache.kafka.clients.admin.UpdateFeaturesResult;
+import org.apache.kafka.common.utils.Exit;
+import org.apache.kafka.common.utils.Utils;
+import org.apache.kafka.server.common.MetadataVersion;
+
+import static net.sourceforge.argparse4j.impl.Arguments.append;
+import static net.sourceforge.argparse4j.impl.Arguments.store;
+import static net.sourceforge.argparse4j.impl.Arguments.storeTrue;
+
+public class FeatureCommand {
+ public static void main(String... args) {
+ Exit.exit(mainNoExit(args));
+ }
+
+ static int mainNoExit(String... args) {
+ try {
+ execute(args);
+ return 0;
+ } catch (TerseException e) {
+ System.err.println(e.getMessage());
+ return 1;
+ } catch (Throwable e) {
+ System.err.println(e.getMessage());
+ System.err.println(Utils.stackTrace(e));
+ return 1;
+ }
+ }
+
+ static void execute(String... args) throws Exception {
+ ArgumentParser parser = ArgumentParsers
+ .newArgumentParser("kafka-features")
+ .defaultHelp(true)
+ .description("This tool manages feature flags in Kafka.");
+ parser
+ .addArgument("--bootstrap-server")
+ .help("A comma-separated list of host:port pairs to use for establishing the connection to the Kafka cluster.")
+ .required(true);
+
+ parser
+ .addArgument("--command-config")
+ .type(Arguments.fileType())
+ .help("Property file containing configs to be passed to Admin Client.");
+ Subparsers subparsers = parser.addSubparsers().dest("command");
+ addDescribeParser(subparsers);
+ addUpgradeParser(subparsers);
+ addDowngradeParser(subparsers);
+ addDisableParser(subparsers);
+
+ Namespace namespace = parser.parseArgsOrFail(args);
+ String command = namespace.getString("command");
+ String configPath = namespace.getString("command_config");
+ Properties properties = (configPath == null) ? new Properties() : Utils.loadProps(configPath);
+
+ String bootstrapServer = namespace.getString("bootstrap_server");
+ if (bootstrapServer != null) {
+ properties.setProperty("bootstrap.servers", bootstrapServer);
+ }
+ if (properties.getProperty("bootstrap.servers") == null) {
+ throw new TerseException("Please specify --bootstrap-server.");
+ }
+
+ switch (command) {
+ case "describe": {
+ try (Admin adminClient = Admin.create(properties)) {
+ handleDescribe(adminClient);
+ }
+ break;
+ }
+ case "upgrade": {
+ try (Admin adminClient = Admin.create(properties)) {
+ handleUpgrade(namespace, adminClient);
+ }
+ break;
+ }
+ case "downgrade": {
+ try (Admin adminClient = Admin.create(properties)) {
+ handleDowngrade(namespace, adminClient);
+ }
+ break;
+ }
+ case "disable": {
+ try (Admin adminClient = Admin.create(properties)) {
+ handleDisable(namespace, adminClient);
+ }
+ break;
+ }
+ default:
+ throw new TerseException("Unknown command " + command);
+ }
+ }
+
+ private static void addDescribeParser(Subparsers subparsers) {
+ subparsers.addParser("describe")
+ .help("Describes the current active feature flags.");
+ }
+
+ private static void addUpgradeParser(Subparsers subparsers) {
+ Subparser upgradeParser = subparsers.addParser("upgrade")
+ .help("Upgrade one or more feature flags.");
+ upgradeParser.addArgument("--metadata")
+ .help("The level to which we should upgrade the metadata. For example, 3.3-IV3.")
+ .action(store());
+ upgradeParser.addArgument("--feature")
+ .help("A feature upgrade we should perform, in feature=level format. For example: `metadata.version=5`.")
+ .action(append());
+ upgradeParser.addArgument("--dry-run")
+ .help("Validate this upgrade, but do not perform it.")
+ .action(storeTrue());
+
+ }
+
+ private static void addDowngradeParser(Subparsers subparsers) {
+ Subparser downgradeParser = subparsers.addParser("downgrade")
+ .help("Upgrade one or more feature flags.");
+ downgradeParser.addArgument("--metadata")
+ .help("The level to which we should downgrade the metadata. For example, 3.3-IV0.")
+ .action(store());
+ downgradeParser.addArgument("--feature")
+ .help("A feature downgrade we should perform, in feature=level format. For example: `metadata.version=5`.")
+ .action(append());
+ downgradeParser.addArgument("--unsafe")
+ .help("Perform this downgrade even if it may irreversibly destroy metadata.")
+ .action(storeTrue());
+ downgradeParser.addArgument("--dry-run")
+ .help("Validate this downgrade, but do not perform it.")
+ .action(storeTrue());
+ }
+
+ private static void addDisableParser(Subparsers subparsers) {
+ Subparser downgradeParser = subparsers.addParser("disable")
+ .help("Disable one or more feature flags. This is the same as downgrading the version to zero.");
+ downgradeParser.addArgument("--feature")
+ .help("A feature flag to disable.")
+ .action(append());
+ downgradeParser.addArgument("--unsafe")
+ .help("Disable this feature flag even if it may irreversibly destroy metadata.")
+ .action(storeTrue());
+ downgradeParser.addArgument("--dry-run")
+ .help("Perform a dry-run of this disable operation.")
+ .action(storeTrue());
+ }
+
+ static String levelToString(String feature, short level) {
+ if (feature.equals(MetadataVersion.FEATURE_NAME)) {
+ try {
+ return MetadataVersion.fromFeatureLevel(level).version();
+ } catch (Throwable e) {
+ throw new RuntimeException("UNKNOWN " + level, e);
+ }
+ }
+ return String.valueOf(level);
+ }
+
+ static void handleDescribe(Admin adminClient) throws ExecutionException, InterruptedException {
+ FeatureMetadata featureMetadata = adminClient.describeFeatures().featureMetadata().get();
+ TreeSet<String> featureList = new java.util.TreeSet<>(featureMetadata.supportedFeatures().keySet());
Review Comment:
We don't need to use `java.util.TreeSet` here
##########
tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java:
##########
@@ -0,0 +1,331 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kafka.tools;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Properties;
+import java.util.TreeSet;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.stream.Collectors;
+import net.sourceforge.argparse4j.ArgumentParsers;
+import net.sourceforge.argparse4j.impl.Arguments;
+import net.sourceforge.argparse4j.inf.ArgumentParser;
+import net.sourceforge.argparse4j.inf.Namespace;
+import net.sourceforge.argparse4j.inf.Subparser;
+import net.sourceforge.argparse4j.inf.Subparsers;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.FeatureMetadata;
+import org.apache.kafka.clients.admin.FeatureUpdate;
+import org.apache.kafka.clients.admin.SupportedVersionRange;
+import org.apache.kafka.clients.admin.UpdateFeaturesOptions;
+import org.apache.kafka.clients.admin.UpdateFeaturesResult;
+import org.apache.kafka.common.utils.Exit;
+import org.apache.kafka.common.utils.Utils;
+import org.apache.kafka.server.common.MetadataVersion;
+
+import static net.sourceforge.argparse4j.impl.Arguments.append;
+import static net.sourceforge.argparse4j.impl.Arguments.store;
+import static net.sourceforge.argparse4j.impl.Arguments.storeTrue;
+
+public class FeatureCommand {
+ public static void main(String... args) {
+ Exit.exit(mainNoExit(args));
+ }
+
+ static int mainNoExit(String... args) {
+ try {
+ execute(args);
+ return 0;
+ } catch (TerseException e) {
+ System.err.println(e.getMessage());
+ return 1;
+ } catch (Throwable e) {
+ System.err.println(e.getMessage());
+ System.err.println(Utils.stackTrace(e));
+ return 1;
+ }
+ }
+
+ static void execute(String... args) throws Exception {
+ ArgumentParser parser = ArgumentParsers
+ .newArgumentParser("kafka-features")
+ .defaultHelp(true)
+ .description("This tool manages feature flags in Kafka.");
+ parser
+ .addArgument("--bootstrap-server")
+ .help("A comma-separated list of host:port pairs to use for establishing the connection to the Kafka cluster.")
+ .required(true);
+
+ parser
+ .addArgument("--command-config")
+ .type(Arguments.fileType())
+ .help("Property file containing configs to be passed to Admin Client.");
+ Subparsers subparsers = parser.addSubparsers().dest("command");
+ addDescribeParser(subparsers);
+ addUpgradeParser(subparsers);
+ addDowngradeParser(subparsers);
+ addDisableParser(subparsers);
+
+ Namespace namespace = parser.parseArgsOrFail(args);
+ String command = namespace.getString("command");
+ String configPath = namespace.getString("command_config");
+ Properties properties = (configPath == null) ? new Properties() : Utils.loadProps(configPath);
+
+ String bootstrapServer = namespace.getString("bootstrap_server");
+ if (bootstrapServer != null) {
+ properties.setProperty("bootstrap.servers", bootstrapServer);
+ }
+ if (properties.getProperty("bootstrap.servers") == null) {
+ throw new TerseException("Please specify --bootstrap-server.");
+ }
+
+ switch (command) {
+ case "describe": {
+ try (Admin adminClient = Admin.create(properties)) {
+ handleDescribe(adminClient);
+ }
+ break;
+ }
+ case "upgrade": {
+ try (Admin adminClient = Admin.create(properties)) {
+ handleUpgrade(namespace, adminClient);
+ }
+ break;
+ }
+ case "downgrade": {
+ try (Admin adminClient = Admin.create(properties)) {
+ handleDowngrade(namespace, adminClient);
+ }
+ break;
+ }
+ case "disable": {
+ try (Admin adminClient = Admin.create(properties)) {
+ handleDisable(namespace, adminClient);
+ }
+ break;
+ }
+ default:
+ throw new TerseException("Unknown command " + command);
+ }
+ }
+
+ private static void addDescribeParser(Subparsers subparsers) {
+ subparsers.addParser("describe")
+ .help("Describes the current active feature flags.");
+ }
+
+ private static void addUpgradeParser(Subparsers subparsers) {
+ Subparser upgradeParser = subparsers.addParser("upgrade")
+ .help("Upgrade one or more feature flags.");
+ upgradeParser.addArgument("--metadata")
+ .help("The level to which we should upgrade the metadata. For example, 3.3-IV3.")
+ .action(store());
+ upgradeParser.addArgument("--feature")
+ .help("A feature upgrade we should perform, in feature=level format. For example: `metadata.version=5`.")
+ .action(append());
+ upgradeParser.addArgument("--dry-run")
+ .help("Validate this upgrade, but do not perform it.")
+ .action(storeTrue());
+
+ }
+
+ private static void addDowngradeParser(Subparsers subparsers) {
+ Subparser downgradeParser = subparsers.addParser("downgrade")
+ .help("Upgrade one or more feature flags.");
+ downgradeParser.addArgument("--metadata")
+ .help("The level to which we should downgrade the metadata. For example, 3.3-IV0.")
+ .action(store());
+ downgradeParser.addArgument("--feature")
+ .help("A feature downgrade we should perform, in feature=level format. For example: `metadata.version=5`.")
+ .action(append());
+ downgradeParser.addArgument("--unsafe")
+ .help("Perform this downgrade even if it may irreversibly destroy metadata.")
+ .action(storeTrue());
+ downgradeParser.addArgument("--dry-run")
+ .help("Validate this downgrade, but do not perform it.")
+ .action(storeTrue());
+ }
+
+ private static void addDisableParser(Subparsers subparsers) {
+ Subparser downgradeParser = subparsers.addParser("disable")
+ .help("Disable one or more feature flags. This is the same as downgrading the version to zero.");
+ downgradeParser.addArgument("--feature")
+ .help("A feature flag to disable.")
+ .action(append());
+ downgradeParser.addArgument("--unsafe")
+ .help("Disable this feature flag even if it may irreversibly destroy metadata.")
+ .action(storeTrue());
+ downgradeParser.addArgument("--dry-run")
+ .help("Perform a dry-run of this disable operation.")
+ .action(storeTrue());
+ }
+
+ static String levelToString(String feature, short level) {
+ if (feature.equals(MetadataVersion.FEATURE_NAME)) {
+ try {
+ return MetadataVersion.fromFeatureLevel(level).version();
+ } catch (Throwable e) {
+ throw new RuntimeException("UNKNOWN " + level, e);
Review Comment:
Should we append throwable `e` in this exception?
##########
tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java:
##########
@@ -0,0 +1,331 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kafka.tools;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Properties;
+import java.util.TreeSet;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.stream.Collectors;
+import net.sourceforge.argparse4j.ArgumentParsers;
+import net.sourceforge.argparse4j.impl.Arguments;
+import net.sourceforge.argparse4j.inf.ArgumentParser;
+import net.sourceforge.argparse4j.inf.Namespace;
+import net.sourceforge.argparse4j.inf.Subparser;
+import net.sourceforge.argparse4j.inf.Subparsers;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.FeatureMetadata;
+import org.apache.kafka.clients.admin.FeatureUpdate;
+import org.apache.kafka.clients.admin.SupportedVersionRange;
+import org.apache.kafka.clients.admin.UpdateFeaturesOptions;
+import org.apache.kafka.clients.admin.UpdateFeaturesResult;
+import org.apache.kafka.common.utils.Exit;
+import org.apache.kafka.common.utils.Utils;
+import org.apache.kafka.server.common.MetadataVersion;
+
+import static net.sourceforge.argparse4j.impl.Arguments.append;
+import static net.sourceforge.argparse4j.impl.Arguments.store;
+import static net.sourceforge.argparse4j.impl.Arguments.storeTrue;
+
+public class FeatureCommand {
+ public static void main(String... args) {
+ Exit.exit(mainNoExit(args));
+ }
+
+ static int mainNoExit(String... args) {
+ try {
+ execute(args);
+ return 0;
+ } catch (TerseException e) {
+ System.err.println(e.getMessage());
+ return 1;
+ } catch (Throwable e) {
+ System.err.println(e.getMessage());
+ System.err.println(Utils.stackTrace(e));
+ return 1;
+ }
+ }
+
+ static void execute(String... args) throws Exception {
+ ArgumentParser parser = ArgumentParsers
+ .newArgumentParser("kafka-features")
+ .defaultHelp(true)
+ .description("This tool manages feature flags in Kafka.");
+ parser
+ .addArgument("--bootstrap-server")
+ .help("A comma-separated list of host:port pairs to use for establishing the connection to the Kafka cluster.")
+ .required(true);
+
+ parser
+ .addArgument("--command-config")
+ .type(Arguments.fileType())
+ .help("Property file containing configs to be passed to Admin Client.");
+ Subparsers subparsers = parser.addSubparsers().dest("command");
+ addDescribeParser(subparsers);
+ addUpgradeParser(subparsers);
+ addDowngradeParser(subparsers);
+ addDisableParser(subparsers);
+
+ Namespace namespace = parser.parseArgsOrFail(args);
+ String command = namespace.getString("command");
+ String configPath = namespace.getString("command_config");
+ Properties properties = (configPath == null) ? new Properties() : Utils.loadProps(configPath);
+
+ String bootstrapServer = namespace.getString("bootstrap_server");
+ if (bootstrapServer != null) {
+ properties.setProperty("bootstrap.servers", bootstrapServer);
+ }
+ if (properties.getProperty("bootstrap.servers") == null) {
+ throw new TerseException("Please specify --bootstrap-server.");
+ }
+
+ switch (command) {
+ case "describe": {
+ try (Admin adminClient = Admin.create(properties)) {
+ handleDescribe(adminClient);
+ }
+ break;
+ }
+ case "upgrade": {
+ try (Admin adminClient = Admin.create(properties)) {
+ handleUpgrade(namespace, adminClient);
+ }
+ break;
+ }
+ case "downgrade": {
+ try (Admin adminClient = Admin.create(properties)) {
+ handleDowngrade(namespace, adminClient);
+ }
+ break;
+ }
+ case "disable": {
+ try (Admin adminClient = Admin.create(properties)) {
+ handleDisable(namespace, adminClient);
+ }
+ break;
+ }
+ default:
+ throw new TerseException("Unknown command " + command);
+ }
+ }
+
+ private static void addDescribeParser(Subparsers subparsers) {
+ subparsers.addParser("describe")
+ .help("Describes the current active feature flags.");
+ }
+
+ private static void addUpgradeParser(Subparsers subparsers) {
+ Subparser upgradeParser = subparsers.addParser("upgrade")
+ .help("Upgrade one or more feature flags.");
+ upgradeParser.addArgument("--metadata")
+ .help("The level to which we should upgrade the metadata. For example, 3.3-IV3.")
+ .action(store());
+ upgradeParser.addArgument("--feature")
+ .help("A feature upgrade we should perform, in feature=level format. For example: `metadata.version=5`.")
+ .action(append());
+ upgradeParser.addArgument("--dry-run")
+ .help("Validate this upgrade, but do not perform it.")
+ .action(storeTrue());
+
+ }
+
+ private static void addDowngradeParser(Subparsers subparsers) {
+ Subparser downgradeParser = subparsers.addParser("downgrade")
+ .help("Upgrade one or more feature flags.");
+ downgradeParser.addArgument("--metadata")
+ .help("The level to which we should downgrade the metadata. For example, 3.3-IV0.")
+ .action(store());
+ downgradeParser.addArgument("--feature")
+ .help("A feature downgrade we should perform, in feature=level format. For example: `metadata.version=5`.")
+ .action(append());
+ downgradeParser.addArgument("--unsafe")
+ .help("Perform this downgrade even if it may irreversibly destroy metadata.")
+ .action(storeTrue());
+ downgradeParser.addArgument("--dry-run")
+ .help("Validate this downgrade, but do not perform it.")
+ .action(storeTrue());
+ }
+
+ private static void addDisableParser(Subparsers subparsers) {
+ Subparser downgradeParser = subparsers.addParser("disable")
+ .help("Disable one or more feature flags. This is the same as downgrading the version to zero.");
+ downgradeParser.addArgument("--feature")
+ .help("A feature flag to disable.")
+ .action(append());
+ downgradeParser.addArgument("--unsafe")
+ .help("Disable this feature flag even if it may irreversibly destroy metadata.")
+ .action(storeTrue());
+ downgradeParser.addArgument("--dry-run")
+ .help("Perform a dry-run of this disable operation.")
+ .action(storeTrue());
+ }
+
+ static String levelToString(String feature, short level) {
+ if (feature.equals(MetadataVersion.FEATURE_NAME)) {
+ try {
+ return MetadataVersion.fromFeatureLevel(level).version();
+ } catch (Throwable e) {
+ throw new RuntimeException("UNKNOWN " + level, e);
+ }
+ }
+ return String.valueOf(level);
+ }
+
+ static void handleDescribe(Admin adminClient) throws ExecutionException, InterruptedException {
+ FeatureMetadata featureMetadata = adminClient.describeFeatures().featureMetadata().get();
+ TreeSet<String> featureList = new java.util.TreeSet<>(featureMetadata.supportedFeatures().keySet());
+ featureList.forEach(feature -> {
+ short finalizedLevel = (featureMetadata.finalizedFeatures().get(feature) == null) ? 0 : featureMetadata.finalizedFeatures().get(feature).maxVersionLevel();
+ SupportedVersionRange range = featureMetadata.supportedFeatures().get(feature);
+ System.out.printf("Feature: %s\tSupportedMinVersion: %s\tSupportedMaxVersion: %s\tFinalizedVersionLevel: %s\tEpoch: %s%n",
+ feature,
+ levelToString(feature, range.minVersion()),
+ levelToString(feature, range.maxVersion()),
+ levelToString(feature, finalizedLevel),
+ (featureMetadata.finalizedFeaturesEpoch().isPresent()) ? featureMetadata.finalizedFeaturesEpoch().get().toString() : "-");
+ });
+ }
+
+ static String metadataVersionsToString(MetadataVersion first, MetadataVersion last) {
+ List<MetadataVersion> versions = Arrays.asList(MetadataVersion.VERSIONS).subList(first.ordinal(), last.ordinal() + 1);
+ return versions.stream()
+ .map(String::valueOf)
+ .collect(Collectors.joining(", "));
+ }
+
+ static void handleUpgrade(Namespace namespace, Admin adminClient) throws TerseException {
+ handleUpgradeOrDowngrade("upgrade", namespace, adminClient, FeatureUpdate.UpgradeType.UPGRADE);
+ }
+
+ static FeatureUpdate.UpgradeType downgradeType(Namespace namespace) {
+ Boolean unsafe = namespace.getBoolean("unsafe");
+ if (unsafe == null || !unsafe) {
+ return FeatureUpdate.UpgradeType.SAFE_DOWNGRADE;
+ } else {
+ return FeatureUpdate.UpgradeType.UNSAFE_DOWNGRADE;
+ }
+ }
+
+ static void handleDowngrade(Namespace namespace, Admin adminClient) throws TerseException {
+ handleUpgradeOrDowngrade("downgrade", namespace, adminClient, downgradeType(namespace));
+ }
+
+ static String[] parseNameAndLevel(String input) {
+ int equalsIndex = input.indexOf("=");
+ if (equalsIndex < 0) {
+ throw new RuntimeException("Can't parse feature=level string " + input + ": equals sign not found.");
+ }
+ String name = input.substring(0, equalsIndex).trim();
+ String levelString = input.substring(equalsIndex + 1).trim();
+ try {
+ Short.parseShort(levelString);
+ } catch (Throwable t) {
+ throw new RuntimeException("Can't parse feature=level string " + input + ": " +
+ "unable to parse " + levelString + " as a short.");
+ }
+ return new String[]{name, levelString};
+ }
+
+ private static void handleUpgradeOrDowngrade(String op, Namespace namespace, Admin admin, FeatureUpdate.UpgradeType upgradeType) throws TerseException {
+ Map<String, FeatureUpdate> updates = new HashMap<>();
+ MetadataVersion version;
+ String metadata = namespace.getString("metadata");
+ if (metadata != null) {
+ try {
+ version = MetadataVersion.fromVersionString(metadata);
+ } catch (Throwable e) {
+ throw new TerseException("Unsupported metadata version " + metadata +
+ ". Supported metadata versions are " + metadataVersionsToString(
+ MetadataVersion.MINIMUM_BOOTSTRAP_VERSION, MetadataVersion.latest()));
+ }
+ updates.put(MetadataVersion.FEATURE_NAME, new FeatureUpdate(version.featureLevel(), upgradeType));
+ }
+
+ List<String> features = namespace.getList("feature");
+ if (features != null) {
+ features.forEach(feature -> {
+ String[] nameAndLevel;
+ nameAndLevel = parseNameAndLevel(feature);
+
+ if (updates.put(nameAndLevel[0], new FeatureUpdate(Short.parseShort(nameAndLevel[1]), upgradeType)) != null) {
+ throw new RuntimeException("Feature " + nameAndLevel[0] + " was specified more than once.");
+ }
+ });
+ }
+
+ update(op, admin, updates, namespace.getBoolean("dry_run"));
+ }
+
+ static void handleDisable(Namespace namespace, Admin adminClient) throws TerseException {
+ FeatureUpdate.UpgradeType upgradeType = downgradeType(namespace);
+ Map<String, FeatureUpdate> updates = new HashMap<>();
+
+ namespace.getList("feature").forEach(feature -> {
+ if (updates.put((String) feature, new FeatureUpdate((short) 0, upgradeType)) != null) {
+ throw new RuntimeException("Feature " + feature + " was specified more than once.");
+ }
+ });
+
+ update("disable", adminClient, updates, namespace.getBoolean("dry_run"));
+ }
+
+ private static void update(String op, Admin admin, Map<String, FeatureUpdate> updates, Boolean dryRun) throws TerseException {
+ if (updates.isEmpty()) {
+ throw new TerseException("You must specify at least one feature to " + op);
+ }
+
+ UpdateFeaturesResult result = admin.updateFeatures(updates, new UpdateFeaturesOptions().validateOnly(dryRun));
+ Map<String, Optional<Throwable>> errors = new HashMap<>();
+ result.values().forEach((feature, future) -> {
+ try {
+ future.get();
+ errors.put(feature, null);
+ } catch (ExecutionException e) {
+ errors.put(feature, Optional.ofNullable(e.getCause()));
+ } catch (Throwable t) {
+ errors.put(feature, Optional.of(t));
+ }
+ });
+
+ AtomicInteger numFailures = new AtomicInteger();
+ errors.keySet().forEach(feature -> {
Review Comment:
I don't think we need to introduce the `AtomicInteger` just for `forEach`. Could we use traditional for loop instead here directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org