You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/09 05:52:34 UTC

[GitHub] [flink] hequn8128 opened a new pull request #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch

hequn8128 opened a new pull request #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch
URL: https://github.com/apache/flink/pull/11350
 
 
   
   ## What is the purpose of the change
   
   The jar of flink-ml-lib should not contain the license and notice file as it actually does not bundle the related dependencies. We should remove these file on branch release-1.10.
   
   This pull request removes the license and notice file in flink-ml-lib module on branch release-1.10.
   
   ## Brief change log
   
     - Removes the license and notice file in flink-ml-lib module on branch release-1.10.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch
URL: https://github.com/apache/flink/pull/11350#issuecomment-596344041
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 0889cb34ef298aa3f84764ec8e1a80ef500897e3 (Mon Mar 09 05:54:29 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch
URL: https://github.com/apache/flink/pull/11350#issuecomment-596347245
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0889cb34ef298aa3f84764ec8e1a80ef500897e3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0889cb34ef298aa3f84764ec8e1a80ef500897e3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0889cb34ef298aa3f84764ec8e1a80ef500897e3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch
URL: https://github.com/apache/flink/pull/11350#issuecomment-596344595
 
 
   CC @zentol @walterddr @carp84 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch
URL: https://github.com/apache/flink/pull/11350#issuecomment-596982475
 
 
   @carp84 @walterddr Appreciate for the review!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 merged pull request #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch

Posted by GitBox <gi...@apache.org>.
hequn8128 merged pull request #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch
URL: https://github.com/apache/flink/pull/11350
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch
URL: https://github.com/apache/flink/pull/11350#issuecomment-596369658
 
 
   @carp84 Thanks a lot for the review. 
   
   The license and notice file is removed just because the corresponding dependencies are not bundled into the jar. 
   
   We don't necessarily bundle this dependency. This is because, currently, on release-1.10, only jar artifacts are released to maven and used by users, i.e., no binaries in opt or lib, so for ml users, he should add the dependencies to the pom file and set it to compile to include the ml classes. Meanwhile, the dependencies(`netlib:core`) will also be included. 
   
   There is also another option to fix this problem as it is descript in the jira, i.e., bundle the dependency in the flink-ml-lib jar. But considering that it is not good to add dependencies in a hotfix version, I would suggest deleting the license and notice file directly.
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch
URL: https://github.com/apache/flink/pull/11350#issuecomment-596347245
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0889cb34ef298aa3f84764ec8e1a80ef500897e3",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152390943",
       "triggerID" : "0889cb34ef298aa3f84764ec8e1a80ef500897e3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0889cb34ef298aa3f84764ec8e1a80ef500897e3 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152390943) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11350: [FLINK-16241][ml] Remove the license and notice file in flink-ml-lib module on release-1.10 branch
URL: https://github.com/apache/flink/pull/11350#issuecomment-596347245
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0889cb34ef298aa3f84764ec8e1a80ef500897e3",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152390943",
       "triggerID" : "0889cb34ef298aa3f84764ec8e1a80ef500897e3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0889cb34ef298aa3f84764ec8e1a80ef500897e3 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/152390943) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services