You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/04/18 12:00:49 UTC
[GitHub] [commons-collections] Isira-Seneviratne opened a new pull request
#149: Add tests for MapUtils.
Isira-Seneviratne opened a new pull request #149: Add tests for MapUtils.
URL: https://github.com/apache/commons-collections/pull/149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] Isira-Seneviratne commented on a change in
pull request #149: [COLLECTIONS-760]: Add tests for MapUtils
Posted by GitBox <gi...@apache.org>.
Isira-Seneviratne commented on a change in pull request #149: [COLLECTIONS-760]: Add tests for MapUtils
URL: https://github.com/apache/commons-collections/pull/149#discussion_r410780989
##########
File path: src/test/java/org/apache/commons/collections4/MapUtilsTest.java
##########
@@ -56,6 +58,7 @@
*/
@SuppressWarnings("boxing")
public class MapUtilsTest extends AbstractAvailableLocalesTest {
+ private static final String THREE = "Three";
Review comment:
On that note, maybe a configuration for [SonarQube](https://www.sonarqube.org/) code analysis could be added?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] Isira-Seneviratne commented on a change in
pull request #149: [COLLECTIONS-760]: Add tests for MapUtils
Posted by GitBox <gi...@apache.org>.
Isira-Seneviratne commented on a change in pull request #149: [COLLECTIONS-760]: Add tests for MapUtils
URL: https://github.com/apache/commons-collections/pull/149#discussion_r410780672
##########
File path: src/test/java/org/apache/commons/collections4/MapUtilsTest.java
##########
@@ -56,6 +58,7 @@
*/
@SuppressWarnings("boxing")
public class MapUtilsTest extends AbstractAvailableLocalesTest {
+ private static final String THREE = "Three";
Review comment:
Assigning "Three" to a constant variable was recommended by SonarLint. It did not provide the same suggestion for "Two" and "key" as those are shorter strings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] kinow commented on a change in pull request
#149: [COLLECTIONS-760]: Add tests for MapUtils
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #149: [COLLECTIONS-760]: Add tests for MapUtils
URL: https://github.com/apache/commons-collections/pull/149#discussion_r410769983
##########
File path: src/test/java/org/apache/commons/collections4/MapUtilsTest.java
##########
@@ -56,6 +58,7 @@
*/
@SuppressWarnings("boxing")
public class MapUtilsTest extends AbstractAvailableLocalesTest {
+ private static final String THREE = "Three";
Review comment:
Hi @Isira-Seneviratne should we have constants for "Two", and "key"? As this is a test class, I think we can have it either way, with or without constants, as the class size is not huge as well. Up to you :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] kinow closed pull request #149:
[COLLECTIONS-760]: Add tests for MapUtils
Posted by GitBox <gi...@apache.org>.
kinow closed pull request #149: [COLLECTIONS-760]: Add tests for MapUtils
URL: https://github.com/apache/commons-collections/pull/149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] kinow commented on a change in pull request
#149: [COLLECTIONS-760]: Add tests for MapUtils
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #149: [COLLECTIONS-760]: Add tests for MapUtils
URL: https://github.com/apache/commons-collections/pull/149#discussion_r410789365
##########
File path: src/test/java/org/apache/commons/collections4/MapUtilsTest.java
##########
@@ -56,6 +58,7 @@
*/
@SuppressWarnings("boxing")
public class MapUtilsTest extends AbstractAvailableLocalesTest {
+ private static final String THREE = "Three";
Review comment:
I believe we were using it at one point. ASF Infra has or had a SonarQube instance running. Now I think there are projects in the ASF using SonarQube, though I am not sure whether that's SonarQube hosted within ASF, or the SonarCloud cloud service. Feel free to reach out via the dev-list and ask it there (as not all Apache Commons developers are subscribed to GitHub, the mailing lists are the best way to discuss things like this :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services