You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/11/17 17:46:58 UTC
Review Request 40388: FALCON-1608: create CLI module with bare-minimum
features
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40388/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1608
https://issues.apache.org/jira/browse/FALCON-1608
Repository: falcon-git
Description
-------
Adding code for early review.
1. Need to reduce dependencies, right now all are copied from client module. Will do once I'm able to get a local server instance running.
2. Have added `.reviewboardrc` file just like https://github.com/apache/lens/blob/master/.reviewboardrc and https://github.com/apache/hive/blob/master/.reviewboardrc, This helps the contributers to create review requests quickly using tools like http://github.com/prongs/apache-dev-tool
Diffs
-----
.reviewboardrc PRE-CREATION
cli/pom.xml PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconBanner.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconHistoryFileProvider.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconPromptProvider.java PRE-CREATION
cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml PRE-CREATION
client/pom.xml d54fabfa4f722559be9e683996042653ce904a4d
pom.xml 6f2c4801655a0ad1f7a15c5adce3dc79ef76560a
Diff: https://reviews.apache.org/r/40388/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 40388: FALCON-1608: create CLI module with
bare-minimum features
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Nov. 22, 2015, 11:21 p.m., Ajay Yadava wrote:
> > .reviewboardrc, line 1
> > <https://reviews.apache.org/r/40388/diff/2/?file=1129250#file1129250line1>
> >
> > It will be nice to add this as part of a separate JIRA so that others are also aware of this new feature and can express their opinion on it.
Created FALCON-1634
> On Nov. 22, 2015, 11:21 p.m., Ajay Yadava wrote:
> > cli/pom.xml, line 10
> > <https://reviews.apache.org/r/40388/diff/2/?file=1129251#file1129251line10>
> >
> > nit: trailing spaces.
Fixed.
> On Nov. 22, 2015, 11:21 p.m., Ajay Yadava wrote:
> > cli/pom.xml, line 135
> > <https://reviews.apache.org/r/40388/diff/2/?file=1129251#file1129251line135>
> >
> > Is this really required?
removed
> On Nov. 22, 2015, 11:21 p.m., Ajay Yadava wrote:
> > cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java, line 100
> > <https://reviews.apache.org/r/40388/diff/2/?file=1129252#file1129252line100>
> >
> > nit: cmdline part might need to be edited out, if we are no longer reading from cmdline.
edited.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40388/#review107341
-----------------------------------------------------------
On Nov. 23, 2015, 10:23 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40388/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 10:23 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1608
> https://issues.apache.org/jira/browse/FALCON-1608
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Adding code for early review.
> 1. Need to reduce dependencies, right now all are copied from client module. Will do once I'm able to get a local server instance running.
> 2. Have added `.reviewboardrc` file just like https://github.com/apache/lens/blob/master/.reviewboardrc and https://github.com/apache/hive/blob/master/.reviewboardrc, This helps the contributers to create review requests quickly using tools like http://github.com/prongs/apache-dev-tool
>
>
> Diffs
> -----
>
> cli/pom.xml PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/skel/FalconBanner.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/skel/FalconHistoryFileProvider.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/skel/FalconPromptProvider.java PRE-CREATION
> cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml PRE-CREATION
> client/pom.xml d54fabfa4f722559be9e683996042653ce904a4d
> pom.xml fad890289396723d29e6e40f3bea8606e380be47
>
> Diff: https://reviews.apache.org/r/40388/diff/
>
>
> Testing
> -------
>
> http://showterm.io/d15a549584556b4c5a02a
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40388: FALCON-1608: create CLI module with
bare-minimum features
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40388/#review107341
-----------------------------------------------------------
.reviewboardrc (line 1)
<https://reviews.apache.org/r/40388/#comment166671>
It will be nice to add this as part of a separate JIRA so that others are also aware of this new feature and can express their opinion on it.
cli/pom.xml (line 10)
<https://reviews.apache.org/r/40388/#comment166429>
nit: trailing spaces.
cli/pom.xml (line 135)
<https://reviews.apache.org/r/40388/#comment166432>
Is this really required?
cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java (line 100)
<https://reviews.apache.org/r/40388/#comment166435>
nit: cmdline part might need to be edited out, if we are no longer reading from cmdline.
- Ajay Yadava
On Nov. 18, 2015, 8:31 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40388/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2015, 8:31 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1608
> https://issues.apache.org/jira/browse/FALCON-1608
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Adding code for early review.
> 1. Need to reduce dependencies, right now all are copied from client module. Will do once I'm able to get a local server instance running.
> 2. Have added `.reviewboardrc` file just like https://github.com/apache/lens/blob/master/.reviewboardrc and https://github.com/apache/hive/blob/master/.reviewboardrc, This helps the contributers to create review requests quickly using tools like http://github.com/prongs/apache-dev-tool
>
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> cli/pom.xml PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/skel/FalconBanner.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/skel/FalconHistoryFileProvider.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/skel/FalconPromptProvider.java PRE-CREATION
> cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml PRE-CREATION
> client/pom.xml d54fabfa4f722559be9e683996042653ce904a4d
> pom.xml 6f2c4801655a0ad1f7a15c5adce3dc79ef76560a
>
> Diff: https://reviews.apache.org/r/40388/diff/
>
>
> Testing
> -------
>
> http://showterm.io/d15a549584556b4c5a02a
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40388: FALCON-1608: create CLI module with
bare-minimum features
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40388/#review107554
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Nov. 23, 2015, 5:12 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40388/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 5:12 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1608
> https://issues.apache.org/jira/browse/FALCON-1608
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Adding code for early review.
> 1. Need to reduce dependencies, right now all are copied from client module. Will do once I'm able to get a local server instance running.
> 2. Have added `.reviewboardrc` file just like https://github.com/apache/lens/blob/master/.reviewboardrc and https://github.com/apache/hive/blob/master/.reviewboardrc, This helps the contributers to create review requests quickly using tools like http://github.com/prongs/apache-dev-tool
>
>
> Diffs
> -----
>
> cli/pom.xml PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/skel/FalconBanner.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/skel/FalconHistoryFileProvider.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/skel/FalconPromptProvider.java PRE-CREATION
> cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml PRE-CREATION
> client/pom.xml d54fabfa4f722559be9e683996042653ce904a4d
> pom.xml fad890289396723d29e6e40f3bea8606e380be47
>
> Diff: https://reviews.apache.org/r/40388/diff/
>
>
> Testing
> -------
>
> http://showterm.io/d15a549584556b4c5a02a
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40388: FALCON-1608: create CLI module with
bare-minimum features
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40388/
-----------------------------------------------------------
(Updated Nov. 27, 2015, 3:40 p.m.)
Review request for Falcon.
Bugs: FALCON-1608
https://issues.apache.org/jira/browse/FALCON-1608
Repository: falcon-git
Description
-------
Adding code for early review.
1. Need to reduce dependencies, right now all are copied from client module. Will do once I'm able to get a local server instance running.
2. Have added `.reviewboardrc` file just like https://github.com/apache/lens/blob/master/.reviewboardrc and https://github.com/apache/hive/blob/master/.reviewboardrc, This helps the contributers to create review requests quickly using tools like http://github.com/prongs/apache-dev-tool
Diffs (updated)
-----
cli/pom.xml PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/FalconInstanceCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconBanner.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconHistoryFileProvider.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconPromptProvider.java PRE-CREATION
cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml PRE-CREATION
client/pom.xml d54fabfa4f722559be9e683996042653ce904a4d
pom.xml 678c87c05a4c911fd789e366b0444953bcb437e8
Diff: https://reviews.apache.org/r/40388/diff/
Testing
-------
http://showterm.io/3daca385fa54411140fbe
Thanks,
Rajat Khandelwal
Re: Review Request 40388: FALCON-1608: create CLI module with
bare-minimum features
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40388/#review108137
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Nov. 23, 2015, 9:07 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40388/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 9:07 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1608
> https://issues.apache.org/jira/browse/FALCON-1608
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Adding code for early review.
> 1. Need to reduce dependencies, right now all are copied from client module. Will do once I'm able to get a local server instance running.
> 2. Have added `.reviewboardrc` file just like https://github.com/apache/lens/blob/master/.reviewboardrc and https://github.com/apache/hive/blob/master/.reviewboardrc, This helps the contributers to create review requests quickly using tools like http://github.com/prongs/apache-dev-tool
>
>
> Diffs
> -----
>
> cli/pom.xml PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/commands/FalconInstanceCommands.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/skel/FalconBanner.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/skel/FalconHistoryFileProvider.java PRE-CREATION
> cli/src/main/java/org/apache/falcon/cli/skel/FalconPromptProvider.java PRE-CREATION
> cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml PRE-CREATION
> client/pom.xml d54fabfa4f722559be9e683996042653ce904a4d
> pom.xml fad890289396723d29e6e40f3bea8606e380be47
>
> Diff: https://reviews.apache.org/r/40388/diff/
>
>
> Testing
> -------
>
> http://showterm.io/3daca385fa54411140fbe
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40388: FALCON-1608: create CLI module with
bare-minimum features
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40388/
-----------------------------------------------------------
(Updated Nov. 23, 2015, 2:37 p.m.)
Review request for Falcon.
Bugs: FALCON-1608
https://issues.apache.org/jira/browse/FALCON-1608
Repository: falcon-git
Description
-------
Adding code for early review.
1. Need to reduce dependencies, right now all are copied from client module. Will do once I'm able to get a local server instance running.
2. Have added `.reviewboardrc` file just like https://github.com/apache/lens/blob/master/.reviewboardrc and https://github.com/apache/hive/blob/master/.reviewboardrc, This helps the contributers to create review requests quickly using tools like http://github.com/prongs/apache-dev-tool
Diffs (updated)
-----
cli/pom.xml PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/FalconInstanceCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconBanner.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconHistoryFileProvider.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconPromptProvider.java PRE-CREATION
cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml PRE-CREATION
client/pom.xml d54fabfa4f722559be9e683996042653ce904a4d
pom.xml fad890289396723d29e6e40f3bea8606e380be47
Diff: https://reviews.apache.org/r/40388/diff/
Testing
-------
http://showterm.io/3daca385fa54411140fbe
Thanks,
Rajat Khandelwal
Re: Review Request 40388: FALCON-1608: create CLI module with
bare-minimum features
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40388/
-----------------------------------------------------------
(Updated Nov. 23, 2015, 1:52 p.m.)
Review request for Falcon.
Bugs: FALCON-1608
https://issues.apache.org/jira/browse/FALCON-1608
Repository: falcon-git
Description
-------
Adding code for early review.
1. Need to reduce dependencies, right now all are copied from client module. Will do once I'm able to get a local server instance running.
2. Have added `.reviewboardrc` file just like https://github.com/apache/lens/blob/master/.reviewboardrc and https://github.com/apache/hive/blob/master/.reviewboardrc, This helps the contributers to create review requests quickly using tools like http://github.com/prongs/apache-dev-tool
Diffs (updated)
-----
cli/pom.xml PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/FalconInstanceCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconBanner.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconHistoryFileProvider.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconPromptProvider.java PRE-CREATION
cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml PRE-CREATION
client/pom.xml d54fabfa4f722559be9e683996042653ce904a4d
pom.xml fad890289396723d29e6e40f3bea8606e380be47
Diff: https://reviews.apache.org/r/40388/diff/
Testing (updated)
-------
http://showterm.io/3daca385fa54411140fbe
Thanks,
Rajat Khandelwal
Re: Review Request 40388: FALCON-1608: create CLI module with
bare-minimum features
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40388/
-----------------------------------------------------------
(Updated Nov. 23, 2015, 10:42 a.m.)
Review request for Falcon.
Bugs: FALCON-1608
https://issues.apache.org/jira/browse/FALCON-1608
Repository: falcon-git
Description
-------
Adding code for early review.
1. Need to reduce dependencies, right now all are copied from client module. Will do once I'm able to get a local server instance running.
2. Have added `.reviewboardrc` file just like https://github.com/apache/lens/blob/master/.reviewboardrc and https://github.com/apache/hive/blob/master/.reviewboardrc, This helps the contributers to create review requests quickly using tools like http://github.com/prongs/apache-dev-tool
Diffs (updated)
-----
cli/pom.xml PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconBanner.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconHistoryFileProvider.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconPromptProvider.java PRE-CREATION
cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml PRE-CREATION
client/pom.xml d54fabfa4f722559be9e683996042653ce904a4d
pom.xml fad890289396723d29e6e40f3bea8606e380be47
Diff: https://reviews.apache.org/r/40388/diff/
Testing
-------
http://showterm.io/d15a549584556b4c5a02a
Thanks,
Rajat Khandelwal
Re: Review Request 40388: FALCON-1608: create CLI module with
bare-minimum features
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40388/
-----------------------------------------------------------
(Updated Nov. 23, 2015, 10:23 a.m.)
Review request for Falcon.
Bugs: FALCON-1608
https://issues.apache.org/jira/browse/FALCON-1608
Repository: falcon-git
Description
-------
Adding code for early review.
1. Need to reduce dependencies, right now all are copied from client module. Will do once I'm able to get a local server instance running.
2. Have added `.reviewboardrc` file just like https://github.com/apache/lens/blob/master/.reviewboardrc and https://github.com/apache/hive/blob/master/.reviewboardrc, This helps the contributers to create review requests quickly using tools like http://github.com/prongs/apache-dev-tool
Diffs (updated)
-----
cli/pom.xml PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconBanner.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconHistoryFileProvider.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconPromptProvider.java PRE-CREATION
cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml PRE-CREATION
client/pom.xml d54fabfa4f722559be9e683996042653ce904a4d
pom.xml fad890289396723d29e6e40f3bea8606e380be47
Diff: https://reviews.apache.org/r/40388/diff/
Testing
-------
http://showterm.io/d15a549584556b4c5a02a
Thanks,
Rajat Khandelwal
Re: Review Request 40388: FALCON-1608: create CLI module with
bare-minimum features
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40388/
-----------------------------------------------------------
(Updated Nov. 18, 2015, 2:01 p.m.)
Review request for Falcon.
Bugs: FALCON-1608
https://issues.apache.org/jira/browse/FALCON-1608
Repository: falcon-git
Description
-------
Adding code for early review.
1. Need to reduce dependencies, right now all are copied from client module. Will do once I'm able to get a local server instance running.
2. Have added `.reviewboardrc` file just like https://github.com/apache/lens/blob/master/.reviewboardrc and https://github.com/apache/hive/blob/master/.reviewboardrc, This helps the contributers to create review requests quickly using tools like http://github.com/prongs/apache-dev-tool
Diffs
-----
.reviewboardrc PRE-CREATION
cli/pom.xml PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconBanner.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconHistoryFileProvider.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconPromptProvider.java PRE-CREATION
cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml PRE-CREATION
client/pom.xml d54fabfa4f722559be9e683996042653ce904a4d
pom.xml 6f2c4801655a0ad1f7a15c5adce3dc79ef76560a
Diff: https://reviews.apache.org/r/40388/diff/
Testing (updated)
-------
http://showterm.io/d15a549584556b4c5a02a
Thanks,
Rajat Khandelwal
Re: Review Request 40388: FALCON-1608: create CLI module with
bare-minimum features
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40388/
-----------------------------------------------------------
(Updated Nov. 18, 2015, 2 p.m.)
Review request for Falcon.
Bugs: FALCON-1608
https://issues.apache.org/jira/browse/FALCON-1608
Repository: falcon-git
Description
-------
Adding code for early review.
1. Need to reduce dependencies, right now all are copied from client module. Will do once I'm able to get a local server instance running.
2. Have added `.reviewboardrc` file just like https://github.com/apache/lens/blob/master/.reviewboardrc and https://github.com/apache/hive/blob/master/.reviewboardrc, This helps the contributers to create review requests quickly using tools like http://github.com/prongs/apache-dev-tool
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
cli/pom.xml PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconBanner.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconHistoryFileProvider.java PRE-CREATION
cli/src/main/java/org/apache/falcon/cli/skel/FalconPromptProvider.java PRE-CREATION
cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml PRE-CREATION
client/pom.xml d54fabfa4f722559be9e683996042653ce904a4d
pom.xml 6f2c4801655a0ad1f7a15c5adce3dc79ef76560a
Diff: https://reviews.apache.org/r/40388/diff/
Testing
-------
Thanks,
Rajat Khandelwal