You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by tomaszguzialek <gi...@git.apache.org> on 2016/01/28 22:53:09 UTC
[GitHub] metamodel pull request: METAMODEL-231
GitHub user tomaszguzialek opened a pull request:
https://github.com/apache/metamodel/pull/88
METAMODEL-231
Reproduced METAMODEL-231 with an integration test as well as tested with Neo4j Sandbox (http://neo4j.com/sandbox).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tomaszguzialek/metamodel METAMODEL-231
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/88.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #88
----
commit 3c2f5bc4034fd390fc56c5bf029c0b498a2ef404
Author: Tomasz Guzialek <to...@apache.org>
Date: 2016-01-28T21:39:57Z
Red test reproducing duplicated relationship properties.
commit 2c652c234c2590f98ddacbdbb2e5b68ec8c12ff1
Author: Tomasz Guzialek <to...@apache.org>
Date: 2016-01-28T21:49:46Z
Using Set instead of a List to eliminate duplicates in relationship properties.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-231
Posted by ClaudiaPHI <gi...@git.apache.org>.
Github user ClaudiaPHI commented on the pull request:
https://github.com/apache/metamodel/pull/88#issuecomment-176652412
Yes. I will do it asp. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-231
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/88#issuecomment-177152623
Great, I'll merge it in. Thanks to both of you for fixing and testing :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-231
Posted by ClaudiaPHI <gi...@git.apache.org>.
Github user ClaudiaPHI commented on the pull request:
https://github.com/apache/metamodel/pull/88#issuecomment-176681523
:+1:
I have tested it and the relationships look nice now.
Movie table:
Person table:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-231
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/88#issuecomment-176652057
Cool, thanks Tomasz! :) @ClaudiaPHI maybe you can give it a test run in DataCleaner before we merge it (if you have time)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-231
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---