[GitHub] [lucene] gsmiller commented on a diff in pull request #995: LUCENE-10603: Migrate remaining SSDV iteration to use docValueCount in production code

[GitBox <gi...@apache.org>]

gsmiller commented on code in PR #995:
URL: https://github.com/apache/lucene/pull/995#discussion_r910315408


##########
lucene/core/src/java/org/apache/lucene/index/CheckIndex.java:
##########
@@ -3382,6 +3383,7 @@ private static void checkSortedSetDocValues(
         seenOrds.set(ord);
         ordCount++;
       }
+

Review Comment:
   Ack. Yeah that's the issue. I don't think the equality check between `ord` and `ord2` after this loop makes sense anymore given that there's no guarantee about what value `ord` will be if calling `nextOrd()` more times than advertised by `docValueCount()`, so I removed the check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org