[GitHub] sdedic opened a new pull request #847: Adapted fix for enabling host modules from jtulach:InstallNbJavacByEr…

[GitBox <gi...@apache.org>]

sdedic opened a new pull request #847: Adapted fix for enabling host modules from jtulach:InstallNbJavacByEr…
URL: https://github.com/apache/incubator-netbeans/pull/847
 
 
   …gonomics. Additional tests provided.
   
   Originally the branch should only add tests, but as it showed up, some corner cases were not handled (I think) still well.
   
   I wanted to cover 3 cases: 
   1. the user enables a module which is a fragment; which should imply enabling the host module as well. 2.  if the user enables the hosting module which just happens to have some fragments around, all those will be enabled and injected (if dependencies are satisfied)
   3. if a fragment is enabled, but its host module is **already loaded and live**, the fragment cannot (reliably) join the constructed classloader. Exception should be thrown.
   
   - I found a place in `AutoupdateCatalogParser` where the `needsRestart` condition is probably wrong: if the module is a fragment, then the restart is always needed. Maybe could be refined more in that the host module must be already installed & enabled.
   
   - in original code, the fragments were registered at the start of `ModuleManager.enable`, so that `simulateEnable` would not report them. I changed that so `ModuleManager` collects fragment list immediately as fragment `Module` objects are created. Then it can always find all fragments for a module.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists