You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2000/10/10 12:55:38 UTC

skel-test.c bogosity(?)

There is a bunch of stuff in skel-test.c that seems to be duplicates for the
"ctype" functionality. APR already offers these in a portable fashion, so
there isn't a need to have that code in there.

See apr_lib.h.

I can see it is doing some other things, but the solution seems rather
overengineered (compared to using a couple apr_ funcs plus specific checks
for the parens/brackets).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Re: skel-test.c bogosity(?)

Posted by Jim Blandy <ji...@savonarola.red-bean.com>.
> There is a bunch of stuff in skel-test.c that seems to be duplicates for the
> "ctype" functionality. APR already offers these in a portable fashion, so
> there isn't a need to have that code in there.
> 
> See apr_lib.h.

I need something that's independent of locale; the syntax of stuff
stored in the filesystem doesn't change if one lives in Brazil.  If
the APR stuff is locale-independent, then that works for me.

> I can see it is doing some other things, but the solution seems rather
> overengineered (compared to using a couple apr_ funcs plus specific checks
> for the parens/brackets).

For the tests, it certainly doesn't matter.  For the actual skel
parser, it probably doesn't matter either, but it was easy...