You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/12/11 11:34:59 UTC
[GitHub] dpa99c commented on issue #368: Fatal error if InAppBrowser is
close immediately
dpa99c commented on issue #368: Fatal error if InAppBrowser is close immediately
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/368#issuecomment-446171433
There is already some defensive coding around async invocation of dialog methods such as [when dismissing on close](https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L523) but these not-null checks should also be added to where the dialog is being explicitly [shown](https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L303) and [hidden](https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L314) because these operations are running on the UI thread, so there is the possibility of such concurrency issues due to the race condition of the dialog instance being destroyed on the another thread before it is invoked on the UI thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org