You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by ji...@apache.org on 2021/11/25 07:52:10 UTC
[dolphinscheduler-website] branch master updated: remove dead links
This is an automated email from the ASF dual-hosted git repository.
jinyleechina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler-website.git
The following commit(s) were added to refs/heads/master by this push:
new 239b94d remove dead links
new 5a2e5e1 Merge pull request #551 from lenboo/master-pr
239b94d is described below
commit 239b94d43814081d81084c76f64a7fb0fc05d8fe
Author: lenboo <ba...@gmail.com>
AuthorDate: Thu Nov 25 15:15:19 2021 +0800
remove dead links
---
community/en-us/development/submit-code.md | 12 +++---------
community/zh-cn/development/submit-code.md | 12 +++---------
2 files changed, 6 insertions(+), 18 deletions(-)
diff --git a/community/en-us/development/submit-code.md b/community/en-us/development/submit-code.md
index 83ca395..a827893 100644
--- a/community/en-us/development/submit-code.md
+++ b/community/en-us/development/submit-code.md
@@ -46,15 +46,9 @@ git push --set-upstream origin dev-1.0
* Submit changes to the remote repository
-* On the github page, click New pull request.
- <p align = "center">
- <img src = "http://geek.analysys.cn/static/upload/221/2019-04-02/90f3abbf-70ef-4334-b8d6-9014c9cf4c7f.png" width = "60%" />
- </p>
-
-* Select the modified local branch and the branch you want to merge with the past, Create pull request.
-<p align = "center">
-<img src = "http://geek.analysys.cn/static/upload/221/2019-04-02/fe7eecfe-2720-4736-951b-b3387cf1ae41.png" width = "60%" />
-</p>
+* On the github page, click "New pull request".
+
+* Select the modified local branch and the branch you want to merge with the past, click "Create pull request".
* Then the community Committers will do CodeReview, and then he will discuss some details (including design, implementation, performance, etc.) with you. When everyone on the team is satisfied with this modification, the commit will be merged into the dev branch
diff --git a/community/zh-cn/development/submit-code.md b/community/zh-cn/development/submit-code.md
index b640f08..3078827 100644
--- a/community/zh-cn/development/submit-code.md
+++ b/community/zh-cn/development/submit-code.md
@@ -10,7 +10,7 @@
日常dev开发分支，新提交的代码都可以pull request到这个分支上。
* branch-1.0.0 发布版本分支
- 发布版本分支，后续会有2.0...等版本分支，版本分支只修改bug，不增加新功能。
+ 发布版本分支，后续会有2.0...等版本分支。
* 把自己仓库clone到本地
@@ -53,15 +53,9 @@ git push --set-upstream origin dev-1.0
* 将修改提交到远端仓库
- * 在github页面，点击New pull request.
- <p align="center">
- <img src="http://geek.analysys.cn/static/upload/221/2019-04-02/90f3abbf-70ef-4334-b8d6-9014c9cf4c7f.png" width="60%" />
- </p>
+ * 在github的PullRequest页面，点击"New pull request".
- * 选择修改完的本地分支和要合并过去的分支，Create pull request.
- <p align="center">
- <img src="http://geek.analysys.cn/static/upload/221/2019-04-02/fe7eecfe-2720-4736-951b-b3387cf1ae41.png" width="60%" />
- </p>
+ * 选择修改完的本地分支和要合并的目的分支，点击"Create pull request".
* 接着社区Committer们会做CodeReview，然后他会与您讨论一些细节（包括设计，实现，性能等）。当团队中所有人员对本次修改满意后，会将提交合并到dev分支