You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/07 10:02:09 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #976: ci: increase the sleep time to fix e2e test unstable issue
nic-chen opened a new pull request #976:
URL: https://github.com/apache/apisix-dashboard/pull/976
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
close #907
close #923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #976: ci: increase the sleep time to fix e2e test unstable issue
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #976:
URL: https://github.com/apache/apisix-dashboard/pull/976#issuecomment-739817496
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/976?src=pr&el=h1) Report
> Merging [#976](https://codecov.io/gh/apache/apisix-dashboard/pull/976?src=pr&el=desc) (8c33599) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #976 +/- ##
==========================================
+ Coverage 43.41% 43.49% +0.07%
==========================================
Files 18 18
Lines 1299 1299
==========================================
+ Hits 564 565 +1
+ Misses 643 642 -1
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/976/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/976?src=pr&el=footer). Last update [8976cca...8c33599](https://codecov.io/gh/apache/apisix-dashboard/pull/976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen merged pull request #976: ci: increase the sleep time to fix e2e test unstable issue
Posted by GitBox <gi...@apache.org>.
nic-chen merged pull request #976:
URL: https://github.com/apache/apisix-dashboard/pull/976
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on pull request #976: ci: increase the sleep time to fix e2e test unstable issue
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #976:
URL: https://github.com/apache/apisix-dashboard/pull/976#issuecomment-739868965
why 0.1 second is not enough？ 0.001 is also should works IMO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #976: ci: increase the sleep time to fix e2e test unstable issue
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #976:
URL: https://github.com/apache/apisix-dashboard/pull/976#issuecomment-739845940
🤔 Could you please describe why increase sleep time will fix the unstable issue in this beginning comment? Then others would know this tip.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #976: ci: increase the sleep time to fix e2e test unstable issue
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #976:
URL: https://github.com/apache/apisix-dashboard/pull/976#issuecomment-740285549
> why 0.1 second is not enough？ 0.001 is also should works IMO
I have updated the description, please have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org