You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Xiao Chen (JIRA)" <ji...@apache.org> on 2018/03/09 06:29:00 UTC

[jira] [Commented] (HDFS-13087) Fix: Snapshots On encryption zones get incorrect EZ settings when encryption zone changes

    [ https://issues.apache.org/jira/browse/HDFS-13087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392481#comment-16392481 ] 

Xiao Chen commented on HDFS-13087:
----------------------------------

Thanks for creating the jira and fixing it, [~GeLiXin].

Was able to do a preliminary review, some comments:
- Any reason to do {{isEqual}} here rather than the canonical override {{equals}} ?
- The new {{readINodeXAttrByPrefixedName}} method seems unnecessary - I think we can reuse the existing method which takes an iip and does {{iip.getPathSnapshotId()}} internally
- getEncryptionZoneForPath: Encryption zones can only be on Dirs, so no point in trying to get an ezi when it's not a dir.
- getEncryptionZoneForPath: I suspect the nullity check is related to some snapshot behavior - could you please add some comments? 

> Fix: Snapshots On encryption zones get incorrect EZ settings when encryption zone changes
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-13087
>                 URL: https://issues.apache.org/jira/browse/HDFS-13087
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: encryption
>    Affects Versions: 3.1.0
>            Reporter: LiXin Ge
>            Assignee: LiXin Ge
>            Priority: Major
>         Attachments: HDFS-13087.001.patch
>
>
> Snapshots are supposed to be immutable and read only, so the EZ settings which in a snapshot path shouldn't change when the origin encryption zone changes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org