You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "tswstarplanet (GitHub)" <gi...@apache.org> on 2019/03/17 04:24:00 UTC

[GitHub] [incubator-dubbo] tswstarplanet opened issue #3682: ConfigCenterConfig's check key wrong

- [ ] I have searched the [issues](https://github.com/apache/incubator-dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/incubator-dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.

### Environment

* Dubbo version: 2.7.1-SNAPSHOT
* Operating System version: MacOS 10.14
* Java version: 1.8

### Steps to reproduce this issue
config 
```xml
<dubbo:configcenter address:xxx check="false"/>
```

### Expected Result
the key in url's parameters should be "config.check", because in apollo dynamic configuration class, it use the key to get the check property
What do you expected from the above steps?

### Actual Result

the key in parameters is check

If there is an exception, please attach the exception trace:

```
Just put your stack trace here!
```


[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3682 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] tswstarplanet closed issue #3682: ConfigCenterConfig's member field's key wrong

Posted by "tswstarplanet (GitHub)" <gi...@apache.org>.
[ issue closed by tswstarplanet ]

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3682 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] chickenlj commented on issue #3682: ConfigCenterConfig's member field's key wrong

Posted by "chickenlj (GitHub)" <gi...@apache.org>.
> So the key of this field in URL's parameters is 'check' because the 'useKeyAsProperty' is false, but in config center configuration class like ApolloDynamicConfiguration, the class use 'config.check' to get the property from parameters of URL.

I don't think the problem you described exists.
To clarify the relations between `check` and `useKeyAsProperty` and also to avoid misunderstanding, I add some comments on @Parameter, please help to check.

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3682 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org