You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/04/23 16:12:11 UTC
[GitHub] [incubator-hugegraph] JackyYangPassion opened a new pull request, #1842: fix hugegraph-test checkstyle issue and move java class to test/java
JackyYangPassion opened a new pull request, #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842
fix hugegraph-test checkstyle issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#discussion_r867430409
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/SecurityManagerTest.java:
##########
@@ -119,15 +119,21 @@ public void testExit() {
@Test
public void testFile() {
// read file
- try (FileInputStream fis = new FileInputStream(new File(""))) {
- } catch (IOException ignored) {}
+ try {
+ FileInputStream fis = new FileInputStream(new File(""));
Review Comment:
the original way is to rely on the automatic close mechanism, can we try:
```java
try (FileInputStream fis = new FileInputStream(new File(""))) {
// pass
} catch (IOException ignored) {
// ignored exception
}
```
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/unit/cache/CachedGraphTransactionTest.java:
##########
@@ -209,7 +210,8 @@ public void testEdgeCacheClearWhenUpdateVertex() {
Whitebox.invoke(cache, "edgesCache", "size"));
cache.addVertexProperty(new HugeVertexProperty<>(v1,
- cache.graph().schema().getPropertyKey("name"),
+ cache.graph().schema()
+ .getPropertyKey("name"),
Review Comment:
can align with `.graph()`
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/SecurityManagerTest.java:
##########
@@ -173,7 +182,11 @@ public void testSocket() throws IOException {
* NOTE: if remove this, gremlin job will call System.loadLibrary("net")
* then throw exception because checkLink failed
*/
- try (ServerSocket serverSocket = new ServerSocket(8200)) {}
+ try {
+ ServerSocket serverSocket = new ServerSocket(8200);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
javeme commented on PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#issuecomment-1107701542
It seems that renaming to "test" package will trigger running all tests, but we expect all tests to be executed in multiple stages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin merged pull request #1842: refact: move java class to test/java & fix test code check-style
Posted by GitBox <gi...@apache.org>.
imbajin merged PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
javeme commented on PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#issuecomment-1109343341
ci error:
```java
Error: Tests run: 727, Failures: 1, Errors: 0, Skipped: 81, Time elapsed: 229.553 s <<< FAILURE! - in com.baidu.hugegraph.core.CoreTestSuite
Error: testGremlinJobAndRestore(com.baidu.hugegraph.core.TaskCoreTest) Time elapsed: 1.215 s <<< FAILURE!
java.lang.AssertionError: expected:<CANCELLING> but was:<FAILED>
at com.baidu.hugegraph.core.TaskCoreTest.testGremlinJobAndRestore(TaskCoreTest.java:629)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] JackyYangPassion commented on a diff in pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
JackyYangPassion commented on code in PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#discussion_r858327935
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/core/AuthTest.java:
##########
@@ -110,9 +110,9 @@ public void testCreateUser() {
Assert.assertThrows(IllegalArgumentException.class, () -> {
authManager.createUser(makeUser("tom", "pass1"));
}, e -> {
- Assert.assertContains("Can't save user", e.getMessage());
- Assert.assertContains("that already exists", e.getMessage());
- });
+ Assert.assertContains("Can't save user", e.getMessage());
Review Comment:
means keeping 12 indents, not 16 ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] JackyYangPassion commented on a diff in pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
JackyYangPassion commented on code in PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#discussion_r868094786
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/unit/cache/CachedGraphTransactionTest.java:
##########
@@ -209,7 +210,8 @@ public void testEdgeCacheClearWhenUpdateVertex() {
Whitebox.invoke(cache, "edgesCache", "size"));
cache.addVertexProperty(new HugeVertexProperty<>(v1,
- cache.graph().schema().getPropertyKey("name"),
+ cache.graph().schema()
+ .getPropertyKey("name"),
Review Comment:
Can you give a code example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on pull request #1842: refact: move java class to test/java & fix test code check-style
Posted by GitBox <gi...@apache.org>.
javeme commented on PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#issuecomment-1124560425
seems didn't move java class to test/java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#discussion_r858377051
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/core/AuthTest.java:
##########
@@ -110,9 +110,9 @@ public void testCreateUser() {
Assert.assertThrows(IllegalArgumentException.class, () -> {
authManager.createUser(makeUser("tom", "pass1"));
}, e -> {
- Assert.assertContains("Can't save user", e.getMessage());
- Assert.assertContains("that already exists", e.getMessage());
- });
+ Assert.assertContains("Can't save user", e.getMessage());
Review Comment:
Yes.
But just now @seagle-yuan said that according to the current style specifications, it may not be possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] JackyYangPassion commented on a diff in pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
JackyYangPassion commented on code in PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#discussion_r866465958
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/api/MetricsApiTest.java:
##########
@@ -100,61 +100,62 @@ public void testMetricsBackend() {
servers = (Map<?, ?>) graph.get("servers");
Assert.assertGte(1, servers.size());
// TODO: Uncomment after fixed #1843
-// for (Map.Entry<?, ?> e : servers.entrySet()) {
-// String key = (String) e.getKey();
-// value = e.getValue();
-// Assert.assertTrue(String.format(
-// "Expect map value for key %s but got %s",
-// key, value),
-// value instanceof Map);
-// host = (Map<?, ?>) value;
-// assertMapContains(host, "mem_max");
-// assertMapContains(host, "mem_committed");
-// assertMapContains(host, "mem_used");
-// assertMapContains(host, "mem_used_readable");
-// assertMapContains(host, "mem_unit");
-//
-// assertMapContains(host, "disk_usage");
-// assertMapContains(host, "disk_usage_readable");
-// assertMapContains(host, "disk_usage_details");
-// assertMapContains(host, "disk_unit");
-//
-// assertMapContains(host, "uptime");
-// assertMapContains(host, "uptime_readable");
-// assertMapContains(host, "time_unit");
-//
-// assertMapContains(host, "estimated_partition_count");
-// assertMapContains(host, "dropped_mutations");
-// assertMapContains(host, "pending_flushes");
-// assertMapContains(host, "key_cache_hit_rate");
-// assertMapContains(host, "bloom_filter_false_ratio");
-//
-// assertMapContains(host, "write_latency_hugegraph");
-// assertMapContains(host, "read_latency_hugegraph");
-// assertMapContains(host, "write_latency_*");
-// assertMapContains(host, "read_latency_*");
-//
-// assertMapContains(host, "key_cache_size");
-// assertMapContains(host, "key_cache_entries");
-// assertMapContains(host, "row_cache_size");
-// assertMapContains(host, "row_cache_entries");
-// assertMapContains(host, "counter_cache_size");
-// assertMapContains(host, "counter_cache_entries");
-//
-// assertMapContains(host, "compaction_completed_tasks");
-// assertMapContains(host, "compaction_pending_tasks");
-// assertMapContains(host, "compaction_bytes_compacted");
-//
-// assertMapContains(host, "live_nodes");
-// assertMapContains(host, "joining_nodes");
-// assertMapContains(host, "moving_nodes");
-// assertMapContains(host, "leaving_nodes");
-// assertMapContains(host, "unreachable_nodes");
-//
-// assertMapContains(host, "keyspaces");
-// assertMapContains(host, "num_tables");
-// assertMapContains(host, "exception_count");
-// }
+
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
javeme commented on PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#issuecomment-1120195864
please rebase latest master branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#discussion_r864431071
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/core/AuthTest.java:
##########
@@ -110,9 +110,9 @@ public void testCreateUser() {
Assert.assertThrows(IllegalArgumentException.class, () -> {
authManager.createUser(makeUser("tom", "pass1"));
}, e -> {
- Assert.assertContains("Can't save user", e.getMessage());
- Assert.assertContains("that already exists", e.getMessage());
- });
+ Assert.assertContains("Can't save user", e.getMessage());
Review Comment:
according to the latest conclusion, we can keep the original style lambda alignment
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/api/MetricsApiTest.java:
##########
@@ -100,61 +100,62 @@ public void testMetricsBackend() {
servers = (Map<?, ?>) graph.get("servers");
Assert.assertGte(1, servers.size());
// TODO: Uncomment after fixed #1843
-// for (Map.Entry<?, ?> e : servers.entrySet()) {
-// String key = (String) e.getKey();
-// value = e.getValue();
-// Assert.assertTrue(String.format(
-// "Expect map value for key %s but got %s",
-// key, value),
-// value instanceof Map);
-// host = (Map<?, ?>) value;
-// assertMapContains(host, "mem_max");
-// assertMapContains(host, "mem_committed");
-// assertMapContains(host, "mem_used");
-// assertMapContains(host, "mem_used_readable");
-// assertMapContains(host, "mem_unit");
-//
-// assertMapContains(host, "disk_usage");
-// assertMapContains(host, "disk_usage_readable");
-// assertMapContains(host, "disk_usage_details");
-// assertMapContains(host, "disk_unit");
-//
-// assertMapContains(host, "uptime");
-// assertMapContains(host, "uptime_readable");
-// assertMapContains(host, "time_unit");
-//
-// assertMapContains(host, "estimated_partition_count");
-// assertMapContains(host, "dropped_mutations");
-// assertMapContains(host, "pending_flushes");
-// assertMapContains(host, "key_cache_hit_rate");
-// assertMapContains(host, "bloom_filter_false_ratio");
-//
-// assertMapContains(host, "write_latency_hugegraph");
-// assertMapContains(host, "read_latency_hugegraph");
-// assertMapContains(host, "write_latency_*");
-// assertMapContains(host, "read_latency_*");
-//
-// assertMapContains(host, "key_cache_size");
-// assertMapContains(host, "key_cache_entries");
-// assertMapContains(host, "row_cache_size");
-// assertMapContains(host, "row_cache_entries");
-// assertMapContains(host, "counter_cache_size");
-// assertMapContains(host, "counter_cache_entries");
-//
-// assertMapContains(host, "compaction_completed_tasks");
-// assertMapContains(host, "compaction_pending_tasks");
-// assertMapContains(host, "compaction_bytes_compacted");
-//
-// assertMapContains(host, "live_nodes");
-// assertMapContains(host, "joining_nodes");
-// assertMapContains(host, "moving_nodes");
-// assertMapContains(host, "leaving_nodes");
-// assertMapContains(host, "unreachable_nodes");
-//
-// assertMapContains(host, "keyspaces");
-// assertMapContains(host, "num_tables");
-// assertMapContains(host, "exception_count");
-// }
+
Review Comment:
we can rebase on master branch https://github.com/apache/incubator-hugegraph/pull/1853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] seagle-yuan commented on a diff in pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
seagle-yuan commented on code in PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#discussion_r869246440
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/RolePermissionTest.java:
##########
@@ -79,59 +85,98 @@ public void testBuiltinNone() {
Assert.assertSame(none, RolePermission.builtin(none));
Assert.assertSame(none, RolePermission.builtin(role1));
- Assert.assertEquals("{\"roles\":{\"none\":{\"NONE\":[{\"type\":\"ALL\",\"label\":\"*\",\"properties\":null}]}}}", none.toJson());
- RolePermission role = RolePermission.fromJson("{\"roles\":{\"none\":{\"NONE\":[{\"type\":\"ALL\",\"label\":\"write\",\"properties\":null}]}}");
+ Assert.assertEquals("{\"roles\":{\"none\":{\"NONE\":[" +
+ "{\"type\":\"ALL\",\"label\":\"*\",\"properties\":null}]}}}"
+ , none.toJson());
+ RolePermission role = RolePermission.fromJson("{\"roles\":{\"none\":{\"NONE\":[" +
Review Comment:
can you put the comma on line 90 on the previous line, and align with left parenthesis
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/unit/cassandra/CassandraTest.java:
##########
@@ -42,7 +41,7 @@ public class CassandraTest {
@Before
public void setup() {
OptionSpace.register("cassandra",
- "com.baidu.hugegraph.backend.store.cassandra.CassandraOptions");
+ "com.baidu.hugegraph.backend.store.cassandra.CassandraOptions");
}
@After
Review Comment:
can you align such as
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#discussion_r857060570
##########
hugegraph-test/src/test/java/com/baidu/hugegraph/core/AuthTest.java:
##########
@@ -1228,13 +1228,13 @@ public void testRolePermission() {
List<HugeResource> rg = HugeResource.parseResources(
"[{\"type\": \"GREMLIN\"}]");
Id graph1v = authManager.createTarget(makeTarget("hugegraph-v",
- "hugegraph",
+ "com/baidu/hugegraph",
Review Comment:
keep hugegraph?
##########
hugegraph-test/src/test/java/com/baidu/hugegraph/core/AuthTest.java:
##########
@@ -1207,13 +1207,13 @@ public void testRolePermission() {
authManager.createUser(makeUser("admin", "pa"));
- Id user0 = authManager.createUser(makeUser("hugegraph", "p0"));
+ Id user0 = authManager.createUser(makeUser("com/baidu/hugegraph", "p0"));
Review Comment:
keep hugegraph?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
imbajin commented on PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#issuecomment-1109584734
@seagle-yuan seems it's confuse and break the IDE default wrap behavior with 8 space in new line
<img width="971" alt="da6b1948d8875a9a7e07b74227e3761d" src="https://user-images.githubusercontent.com/17706099/165272267-822e26fe-793d-4ca9-828b-3d3a503ac064.png">
consider keep the original style is better (or maybe we need a easy way to keep the wrap unify)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#discussion_r858270768
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/core/TaskCoreTest.java:
##########
@@ -591,11 +613,11 @@ public void testGremlinJobAndRestore() throws Exception {
HugeGraph graph = graph();
TaskScheduler scheduler = graph.taskScheduler();
- String gremlin = "System.out.println('task start');" +
+ String gremlin = "LOG.info(\"task start\");" +
Review Comment:
maybe there is no LOG import, can try groovy `println`
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java:
##########
@@ -2703,13 +2703,6 @@ public void testQueryOlapWithUpdates() {
graph.readMode(GraphReadMode.ALL);
// FIXME: expect to throw error here
-// Assert.assertThrows(IllegalArgumentException.class, () -> {
-// graph.traversal().V().has("pagerank", 0.1D).toList();
-// }, e -> {
-// Assert.assertContains("not allowed to query by olap " +
-// "when there are uncommitted records",
-// e.toString());
-// });
Review Comment:
can we keep this code block?
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/core/AuthTest.java:
##########
@@ -110,9 +110,9 @@ public void testCreateUser() {
Assert.assertThrows(IllegalArgumentException.class, () -> {
authManager.createUser(makeUser("tom", "pass1"));
}, e -> {
- Assert.assertContains("Can't save user", e.getMessage());
- Assert.assertContains("that already exists", e.getMessage());
- });
+ Assert.assertContains("Can't save user", e.getMessage());
Review Comment:
can we keep the origin indentation style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#issuecomment-1109396219
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1842](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5f72ead) into [master](https://codecov.io/gh/apache/incubator-hugegraph/commit/85b01b233392cd991739a035773629c7bf90e23b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85b01b2) will **decrease** coverage by `13.65%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1842 +/- ##
=============================================
- Coverage 64.45% 50.80% -13.66%
+ Complexity 914 659 -255
=============================================
Files 447 447
Lines 38040 38037 -3
Branches 5389 5376 -13
=============================================
- Hits 24520 19324 -5196
- Misses 11000 16602 +5602
+ Partials 2520 2111 -409
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...du/hugegraph/backend/store/mysql/MysqlMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLW15c3FsL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL215c3FsL015c3FsTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...hugegraph/backend/store/raft/RaftStoreClosure.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9SYWZ0U3RvcmVDbG9zdXJlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...hugegraph/job/schema/OlapPropertyKeyCreateJob.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2pvYi9zY2hlbWEvT2xhcFByb3BlcnR5S2V5Q3JlYXRlSm9iLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...hugegraph/job/schema/OlapPropertyKeyRemoveJob.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2pvYi9zY2hlbWEvT2xhcFByb3BlcnR5S2V5UmVtb3ZlSm9iLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...egraph/backend/store/hbase/HbaseStoreProvider.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWhiYXNlL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL2hiYXNlL0hiYXNlU3RvcmVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...graph/backend/store/scylladb/ScyllaDBFeatures.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLXNjeWxsYWRiL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL3NjeWxsYWRiL1NjeWxsYURCRmVhdHVyZXMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ackend/store/cassandra/CassandraStoreProvider.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNhc3NhbmRyYS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYmFja2VuZC9zdG9yZS9jYXNzYW5kcmEvQ2Fzc2FuZHJhU3RvcmVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../hugegraph/backend/store/raft/StoreSerializer.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9TdG9yZVNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-98.42%)` | :arrow_down: |
| [.../backend/store/scylladb/ScyllaDBStoreProvider.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLXNjeWxsYWRiL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL3NjeWxsYWRiL1NjeWxsYURCU3RvcmVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-97.30%)` | :arrow_down: |
| [...h/backend/store/scylladb/ScyllaDBTablesWithMV.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLXNjeWxsYWRiL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL3NjeWxsYWRiL1NjeWxsYURCVGFibGVzV2l0aE1WLmphdmE=) | `0.00% <0.00%> (-96.04%)` | :arrow_down: |
| ... and [131 more](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [85b01b2...5f72ead](https://codecov.io/gh/apache/incubator-hugegraph/pull/1842?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] JackyYangPassion commented on pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
JackyYangPassion commented on PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#issuecomment-1119233048
Change the checkstyle version and keep the original lambda structure. At present, this module has been reduced from 1500+ to 900+. It is expected to be repaired this week
mvn compile checkstyle:checkstyle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] seagle-yuan commented on pull request #1842: fix hugegraph-test checkstyle issue and move java class to test/java
Posted by GitBox <gi...@apache.org>.
seagle-yuan commented on PR #1842:
URL: https://github.com/apache/incubator-hugegraph/pull/1842#issuecomment-1115963200
> @seagle-yuan seems it's confuse and break the IDE default wrap behavior with 8 space in new line
>
> <img alt="da6b1948d8875a9a7e07b74227e3761d" width="971" src="https://user-images.githubusercontent.com/17706099/165272267-822e26fe-793d-4ca9-828b-3d3a503ac064.png">
>
> consider keep the original style is better (or maybe we need a easy way to keep the wrap unify)
need to update checkstyle version
#1857
https://github.com/checkstyle/checkstyle/issues/3342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org