You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/01/09 21:49:30 UTC

[I] Clarify logic in `nth_value` function [datafusion]

alamb opened a new issue, #14063:
URL: https://github.com/apache/datafusion/issues/14063

                 took me a while to figure out what's happening here; maybe instead check slice.nulls() explicitly and return None if it doesn't exist (i.e. there's no nulls)?
   
   also the pre-existing short-circuiting might be useful in cases where the nulls() index exists but valid_indices() truly is empty (i.e. the array is completely nulls)?
   
   _Originally posted by @Blizzara in https://github.com/apache/datafusion/pull/14042#discussion_r1907148647_
               


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Clarify logic in `nth_value` function [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #14063: Clarify logic in `nth_value` function
URL: https://github.com/apache/datafusion/issues/14063


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Clarify logic in `nth_value` function [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #14063:
URL: https://github.com/apache/datafusion/issues/14063#issuecomment-2581309897

   I think this is a good initial issue for someone


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Clarify logic in `nth_value` function [datafusion]

Posted by "zjregee (via GitHub)" <gi...@apache.org>.
zjregee commented on issue #14063:
URL: https://github.com/apache/datafusion/issues/14063#issuecomment-2581645662

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org