[jira] [Comment Edited] (FLINK-30489) flink-sql-connector-pulsar doesn't shade all dependencies

["Yufan Sheng (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-30489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652982#comment-17652982 ] 

Yufan Sheng edited comment on FLINK-30489 at 12/30/22 1:03 AM:
---------------------------------------------------------------

We didn't shade these dependencies because these dependencies are not always required for Pulsar connector. Such as {{org.bouncycastel}}, you will need it only if you use the end-to-end encryption.

But we can truly shade all the dependencies.


was (Author: syhily):
We didn't shade these dependencies because these dependencies are not always required for Pulsar connector. Such as {{org.bouncycastel}}, you will need it only if you use the end-to-end encryption.

> flink-sql-connector-pulsar doesn't shade all dependencies
> ---------------------------------------------------------
>
>                 Key: FLINK-30489
>                 URL: https://issues.apache.org/jira/browse/FLINK-30489
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / Pulsar
>    Affects Versions: 1.16.0
>            Reporter: Henri Yandell
>            Priority: Major
>
> Looking at [https://repo1.maven.org/maven2/org/apache/flink/flink-sql-connector-pulsar/1.16.0/flink-sql-connector-pulsar-1.16.0.jar] I'm seeing that some dependencies are shaded (com.fasterxml, com.yahoo etc), but others are not (org.sfl4j, org.bouncycastel, com.scurrilous, ...) and will presumably clash with other jar files.
> Additionally, this bundling is going on in the '.jar' file rather than in a more clearly indicated separate -bundle or -shaded jar file. 
> As a jar file this seems confusing and potentially bug inducing; though I note I'm just a review of the jar and not Flink experienced.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)