[GitHub] [netbeans] michaelsembwever edited a comment on issue #1216: NETBEANS-888 Open Recent file not working

[GitBox <gi...@apache.org>]

michaelsembwever edited a comment on issue #1216: NETBEANS-888 Open Recent file not working
URL: https://github.com/apache/netbeans/pull/1216#issuecomment-486869661
 
 
   @geertjanw ,
   
   > So it was macos specific, didn't know that. And also related to some change in the JDK after 1.8, but what could it be (just curious really).
   
   I didn't (don't) have the time to hunt that down.
   The existing code was recreating the menuItems every time the popup menu listener declared (notified) that the jmenuitem was made visible. The ScreenMenuItems was then without reference back to these menuItems, and so there's was no actionListener and the event was not enabled.
   
   Changing it so that the menuItems were only recreated when the history in RecentFiles changed, solved the problem, probably because the ScreenMenuItems <-> menuItem referencing is done before the popup menu change support kicks in, but that's just a guess.
   
   There's a bit more of my analysis info in https://issues.apache.org/jira/browse/NETBEANS-888

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists