You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Thomas Heigl (JIRA)" <ji...@apache.org> on 2018/06/10 11:31:00 UTC
[jira] [Created] (WICKET-6560) Improve serialization warnings in
ChainingModel
Thomas Heigl created WICKET-6560:
------------------------------------
Summary: Improve serialization warnings in ChainingModel
Key: WICKET-6560
URL: https://issues.apache.org/jira/browse/WICKET-6560
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 8.0.0
Reporter: Thomas Heigl
After porting our app to Wicket 8, I'm getting these warnings on my test environment:
{quote}WAR o.a.w.model.ChainingModel It is not a good idea to reference a non-serializable instance in models directly as it may lead to serialization problems{quote}
The warning is OK, but it gives me absolutely no hint where to look for the issue. Could you please add the (simple) class name of the model object to the warning message?
Currently, the only way for me to find these issues is with a breakpoint in `ChainingModel` and clicking through my application until I hit the warning.
Also the warning is logged for `null` objects, which probably shouldn't happen.
{quote}public ChainingModel(final Object modelObject)
{
if (modelObject instanceof Session)
{
LOG.warn("It is not a good idea to reference the .........");
} else if (modelObject instanceof Serializable == false)
{
LOG.warn("It is not a good idea to reference a non-serializable instance ....");
}
target = modelObject;
}{quote}
It should read something like:
{quote}if (modelObject != null && modelObject instanceof Serializable == false){quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)