You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/11/22 10:31:27 UTC
[GitHub] [james-project] quantranhong1999 opened a new pull request, #1327: JAMES-3861 EmailDelivery push is used too much
quantranhong1999 opened a new pull request, #1327:
URL: https://github.com/apache/james-project/pull/1327
Only push `EmailDelivery` for receiving emails (local delivery).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #1327: JAMES-3861 EmailDelivery push is used too much
Posted by GitBox <gi...@apache.org>.
chibenwa merged PR #1327:
URL: https://github.com/apache/james-project/pull/1327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a diff in pull request #1327: JAMES-3861 EmailDelivery push is used too much
Posted by GitBox <gi...@apache.org>.
chibenwa commented on code in PR #1327:
URL: https://github.com/apache/james-project/pull/1327#discussion_r1029172274
##########
mailbox/event/json/src/main/scala/org/apache/james/event/json/MailboxEventSerializer.scala:
##########
@@ -164,7 +165,8 @@ private object ScalaConverter {
user = event.getUsername,
path = MailboxPath.fromJava(event.getMailboxPath),
mailboxId = event.getMailboxId,
- added = event.getAdded.asScala.view.mapValues(DTOs.MessageMetaData.fromJava).toMap)
+ added = event.getAdded.asScala.view.mapValues(DTOs.MessageMetaData.fromJava).toMap,
+ isDelivery = IsDelivery(event.isDelivery))
Review Comment:
Please handle format migration: do we support when this field is missing? Akka legacy format?
(write a unit test for this...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org