You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/11/25 20:33:19 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new issue #6385: Reserved consistentHashQueryParameters cause internal server error

ocket8888 opened a new issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385


   ## This Bug Report affects these Traffic Control components:
   - Traffic Ops
   
   ## Current behavior:
   Trying to update or create a Delivery Service to use a reserved query string parameter name like "trred" or "format" causes a 500 Internal Server Error response.
   
   ## Expected behavior:
   I'm almost certain the old behavior was more proper; the API should return a client-level error and accompanying Alert that tells the user they can't do what they're trying to do.
   
   ## Steps to reproduce:
   ```console
   $ topost -kp deliveryservices '{
   	"active": false,
   	"cdnId": 2,
   	"displayName": "test",
   	"dnsBypassCname": "test",
   	"dscp": 1,
   	"geoLimit": 1,
   	"geoLimitCountries": "[US, CA]",
   	"geoProvider": -7,
   	"initialDispersion": 1,
   	"ipv6RoutingEnabled": true,
   	"logsEnabled": true,
   	"missLat": 0,
   	"missLong": 0,
   	"multiSiteOrigin": false,
   	"orgServerFqdn": "http://origin.infra.ciab.test",
   	"protocol": 7,
   	"qstringIgnore": 5,
   	"rangeRequestHandling": 0,
   	"regionalGeoBlocking": false,
   	"tenantId": 1,
   	"typeId": 1,
   	"xmlId": "test",
   	"consistentHashQueryParams": ["format", "something fine", "trred"]
   }'
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on issue #6385: Reserved consistentHashQueryParameters cause internal server error

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385#issuecomment-993879232


   > ok, I tried to build it with docker-compose 1.25.4 but the compose version 3.8 in YAML files only supported from version 1.25.5 https://github.com/docker/compose/releases/tag/1.25.5. adding it here on the hope it helps someone.
   
   The Python version of docker-compose (versions < v2.0.0) is no longer supported. They rewrote docker-compose in Go.
   
   > Also i am getting this error, Step 10/35 : FROM common-traffic-server-dependencies AS common-cache-config-layers ---> f76f2258a217 Step 11/35 : COPY infrastructure/cdn-in-a-box/cache/trafficserver.rpm /trafficserver.rpm COPY failed: file not found in build context or excluded by .dockerignore: stat infrastructure/cdn-in-a-box/cache/trafficserver.rpm: file does not exist ERROR: Service 'edge' failed to build : Build failed
   > 
   > The RPM file is not found in given path infrastructure/cdn-in-a-box/cache/trafficserver.rpm. Should it be built separately?
   
   All of the RPMs necessary to run CDN in a Box will be built and placed in the correct locations if you just run make` from the `infrastructure/cdn-in-a-box` directory. From the [documentation](https://traffic-control-cdn.readthedocs.io/en/latest/admin/quick_howto/ciab.html#building):
   
   https://github.com/apache/trafficcontrol/blob/e67c967a8b73bdddf75851d66c051694b20373a9/docs/source/admin/quick_howto/ciab.rst#L41


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman edited a comment on issue #6385: Reserved consistentHashQueryParameters cause internal server error

Posted by GitBox <gi...@apache.org>.
zrhoffman edited a comment on issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385#issuecomment-993879232


   > ok, I tried to build it with docker-compose 1.25.4 but the compose version 3.8 in YAML files only supported from version 1.25.5 https://github.com/docker/compose/releases/tag/1.25.5. adding it here on the hope it helps someone.
   
   The Python version of docker-compose (versions < v2.0.0) is no longer supported. They rewrote docker-compose in Go.
   
   > Also i am getting this error, Step 10/35 : FROM common-traffic-server-dependencies AS common-cache-config-layers ---> f76f2258a217 Step 11/35 : COPY infrastructure/cdn-in-a-box/cache/trafficserver.rpm /trafficserver.rpm COPY failed: file not found in build context or excluded by .dockerignore: stat infrastructure/cdn-in-a-box/cache/trafficserver.rpm: file does not exist ERROR: Service 'edge' failed to build : Build failed
   > 
   > The RPM file is not found in given path infrastructure/cdn-in-a-box/cache/trafficserver.rpm. Should it be built separately?
   
   All of the RPMs necessary to run CDN in a Box will be built and placed in the correct locations if you just run `make` from the `infrastructure/cdn-in-a-box` directory. From the [documentation](https://traffic-control-cdn.readthedocs.io/en/latest/admin/quick_howto/ciab.html#building):
   
   https://github.com/apache/trafficcontrol/blob/e67c967a8b73bdddf75851d66c051694b20373a9/docs/source/admin/quick_howto/ciab.rst#L41


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] asheikm commented on issue #6385: Reserved consistentHashQueryParameters cause internal server error

Posted by GitBox <gi...@apache.org>.
asheikm commented on issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385#issuecomment-993411176


   Hi 
   Can this bug reproduced using cdn-in-box ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] asheikm commented on issue #6385: Reserved consistentHashQueryParameters cause internal server error

Posted by GitBox <gi...@apache.org>.
asheikm commented on issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385#issuecomment-994305995


   Ok, Thanks , It is building now, stragely, make takes lot of time, I am on VM OL8, which is taken as CentOS 8, thats fine anyway. It is still building


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on issue #6385: Reserved consistentHashQueryParameters cause internal server error

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385#issuecomment-994974893


   > `make` builds sequentially. I think about 80% of its time is spent on building the builder image for the ATS RPM (citation needed). `make -j` is marginally faster. When building on systems that use `rpm` to manage packages (which is LSB-compliant, to be fair) can build quite a bit faster with `make native`. The absolute fastest is `make -j native`, where supported. But at any rate, building once will expedite future builds.
   
   `make native` is temporarily broken due to #6419


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] asheikm commented on issue #6385: Reserved consistentHashQueryParameters cause internal server error

Posted by GitBox <gi...@apache.org>.
asheikm commented on issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385#issuecomment-994625201


   ok, I got it, now the cdn-in-a-box is running fine. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on issue #6385: Reserved consistentHashQueryParameters cause internal server error

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385#issuecomment-994368413


   `make` builds sequentially. I think about 80% of its time is spent on building the builder image for the ATS RPM (citation needed). `make -j` is marginally faster. When building on systems that use `rpm` to manage packages (which is LSB-compliant, to be fair) can build quite a bit faster with `make native`. The absolute fastest is `make -j native`, where supported. But at any rate, building once will expedite future builds. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] asheikm commented on issue #6385: Reserved consistentHashQueryParameters cause internal server error

Posted by GitBox <gi...@apache.org>.
asheikm commented on issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385#issuecomment-995193547


   > > `make` builds sequentially. I think about 80% of its time is spent on building the builder image for the ATS RPM (citation needed). `make -j` is marginally faster. When building on systems that use `rpm` to manage packages (which is LSB-compliant, to be fair) can build quite a bit faster with `make native`. The absolute fastest is `make -j native`, where supported. But at any rate, building once will expedite future builds.
   > 
   > `make native` is temporarily broken due to #6419
   
   Fix merged with master now https://github.com/apache/trafficcontrol/pull/6420


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on issue #6385: Reserved consistentHashQueryParameters cause internal server error

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385#issuecomment-995473730


   `topost` is a utility provided by the Python client for Traffic Ops. It has an unofficial hosting on PyPI: https://pypi.org/project/Apache-TrafficControl/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] asheikm commented on issue #6385: Reserved consistentHashQueryParameters cause internal server error

Posted by GitBox <gi...@apache.org>.
asheikm commented on issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385#issuecomment-995397452


   can we directly issue this command on cli ? or with curl ? 
   ```
   $ topost -kp deliveryservices '{
   	"active": false,
   	"cdnId": 2,
   	"displayName": "test",
   	"dnsBypassCname": "test",
   	"dscp": 1,
   	"geoLimit": 1,
   	"geoLimitCountries": "[US, CA]",
   	"geoProvider": -7,
   	"initialDispersion": 1,
   	"ipv6RoutingEnabled": true,
   	"logsEnabled": true,
   	"missLat": 0,
   	"missLong": 0,
   	"multiSiteOrigin": false,
   	"orgServerFqdn": "http://origin.infra.ciab.test",
   	"protocol": 7,
   	"qstringIgnore": 5,
   	"rangeRequestHandling": 0,
   	"regionalGeoBlocking": false,
   	"tenantId": 1,
   	"typeId": 1,
   	"xmlId": "test",
   	"consistentHashQueryParams": ["format", "something fine", "trred"]
   }'
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] asheikm edited a comment on issue #6385: Reserved consistentHashQueryParameters cause internal server error

Posted by GitBox <gi...@apache.org>.
asheikm edited a comment on issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385#issuecomment-995397452


   can we directly issue this command on cli ? or with curl ? 
   ```
   $ topost -kp deliveryservices '{
   	"active": false,
   	"cdnId": 2,
   	"displayName": "test",
   	"dnsBypassCname": "test",
   	"dscp": 1,
   	"geoLimit": 1,
   	"geoLimitCountries": "[US, CA]",
   	"geoProvider": -7,
   	"initialDispersion": 1,
   	"ipv6RoutingEnabled": true,
   	"logsEnabled": true,
   	"missLat": 0,
   	"missLong": 0,
   	"multiSiteOrigin": false,
   	"orgServerFqdn": "http://origin.infra.ciab.test",
   	"protocol": 7,
   	"qstringIgnore": 5,
   	"rangeRequestHandling": 0,
   	"regionalGeoBlocking": false,
   	"tenantId": 1,
   	"typeId": 1,
   	"xmlId": "test",
   	"consistentHashQueryParams": ["format", "something fine", "trred"]
   }'
   ```
   Edit: I got doc link, let me try curl with post request for this, in the mean time, how to use `topost` if it is tool ? or is it alias ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on issue #6385: Reserved consistentHashQueryParameters cause internal server error

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385#issuecomment-993632604


   yes, it's not dependent on environment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] asheikm commented on issue #6385: Reserved consistentHashQueryParameters cause internal server error

Posted by GitBox <gi...@apache.org>.
asheikm commented on issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385#issuecomment-993825643


   ok, I tried to build it with docker-compose 1.25.4 but the compose version 3.8 in YAML files only supported from version 1.25.5 https://github.com/docker/compose/releases/tag/1.25.5. adding it here on the hope it helps someone.
   
   Also i am getting this error,
   Step 10/35 : FROM common-traffic-server-dependencies AS common-cache-config-layers
    ---> f76f2258a217
   Step 11/35 : COPY infrastructure/cdn-in-a-box/cache/trafficserver.rpm /trafficserver.rpm
   COPY failed: file not found in build context or excluded by .dockerignore: stat infrastructure/cdn-in-a-box/cache/trafficserver.rpm: file does not exist
   ERROR: Service 'edge' failed to build : Build failed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] asheikm edited a comment on issue #6385: Reserved consistentHashQueryParameters cause internal server error

Posted by GitBox <gi...@apache.org>.
asheikm edited a comment on issue #6385:
URL: https://github.com/apache/trafficcontrol/issues/6385#issuecomment-993825643


   ok, I tried to build it with docker-compose 1.25.4 but the compose version 3.8 in YAML files only supported from version 1.25.5 https://github.com/docker/compose/releases/tag/1.25.5. adding it here on the hope it helps someone.
   
   Also i am getting this error,
   Step 10/35 : FROM common-traffic-server-dependencies AS common-cache-config-layers
    ---> f76f2258a217
   Step 11/35 : COPY infrastructure/cdn-in-a-box/cache/trafficserver.rpm /trafficserver.rpm
   COPY failed: file not found in build context or excluded by .dockerignore: stat infrastructure/cdn-in-a-box/cache/trafficserver.rpm: file does not exist
   ERROR: Service 'edge' failed to build : Build failed
   
   The RPM file is not found in given path  infrastructure/cdn-in-a-box/cache/trafficserver.rpm. 
   Should it be built separately? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org